Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pip install without editable mode, fix ModuleNotFoundError #956

Merged
merged 2 commits into from
May 27, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented May 27, 2022

Description of proposed changes

Catches and prevents errors such as ModuleNotFoundError: No module named 'augur.io_support', introduced in #929.

  • figure out why CI didn't catch this
  • add test to prevent future breakage

Related issue(s)

N/A

Testing

  • See CI status before/after adding __init__.py.
  • Also tested locally by @rneher and I

@victorlin victorlin self-assigned this May 27, 2022
The nature of editable mode can mask some ModuleNotFoundErrors that surface with a normal pip install.

No reason for editable mode in CI and the test script, which both install in an ephemeral conda environment without using the benefits of editable mode.
@victorlin victorlin force-pushed the victorlin/add-io-support-init branch from 6935e70 to e873a34 Compare May 27, 2022 17:44
Prevents errors such as ModuleNotFoundError: No module named 'augur.io_support'.
@victorlin victorlin changed the title Add io_support/__init__.py tests: pip install without editable mode, fix ModuleNotFoundError May 27, 2022
@victorlin victorlin marked this pull request as ready for review May 27, 2022 18:33
@victorlin victorlin requested a review from a team May 27, 2022 18:33
@victorlin victorlin merged commit 446b39d into master May 27, 2022
@victorlin victorlin deleted the victorlin/add-io-support-init branch May 27, 2022 21:34
@victorlin victorlin added this to the Major release 16.0.0 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants