-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade treetime to v0.7 #431
Conversation
…f the parallel implementation that existed in augur traits.
Validation is failing, however, since augur is now exporting mutations like |
…ous with the latter being default (as it was for vcf, now also for fasta input).
…do in the v2-schema
… missing info by mapping them to 'N'
With the updated v1 schema, this passes tests now. Should be ready to merge and address #429 |
This keeps default augur behavior unchanged despite the TreeTime upgrade. By adding the --keep-ambiguous flag, new behavior can be requested. This seemed safer in terms of not causing unexpected behavior for users.
Hi @rjabhinav, it's best to open a new issue if you need help. Please don't reply to this PR anymore, but open an issue if you need further help. We apologise that the instructions for the Zika tutorial have gone out of date somewhat. |
creating this PR not for immediate merging but for discussion and testing.
TreeTime underwent a number of changes from 0.6 to 0.7. Among other things
node.sequence
anymore as these are now protectedOur traits code messes with
node.sequences
, so this needed changing. Other than that, I have not noticed any problems but it will be good to check more thoroughly, also test treetime.