Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update treetime #429

Closed
rneher opened this issue Dec 23, 2019 · 2 comments
Closed

update treetime #429

rneher opened this issue Dec 23, 2019 · 2 comments

Comments

@rneher
Copy link
Member

rneher commented Dec 23, 2019

I'll soon release TreeTime 0.7. Most changes are internal, but some might affect augur since augur at times reaches deep into the "internals" of TreeTime. I have been running augur without problem using TT 0.7 but it should be tested more broadly. Two changes in particular might change some of augur's behavior:

  • TreeTime no longer reconstructs ambiguous sequence of tips by default. This behavior was unexpected to most and after separating input and inferred sequence more cleanly in TT this seemed obvious to change. For the mugration analysis, however, tip reconstruction might be of interest.
  • The overall mugration rate is now estimated numerically instead of relying on the linear approximation -- at least in the treetime mugration command. We probably would want to do this as well in augur traits.
@rneher
Copy link
Member Author

rneher commented Dec 23, 2019

just ran a few tests. One test fails here:
https://github.com/nextstrain/augur/blob/master/augur/traits.py#L75
This is no longer allowed since node.sequence is now a protected attribute that you can't set from the outside.

This could either be fixed by using the same construction as done here
https://github.com/nextstrain/augur/blob/master/augur/traits.py#L75

or by replacing the entire logic by
https://github.com/neherlab/treetime/blob/master/treetime/wrappers.py#L678

@jameshadfield
Copy link
Member

Released with 6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants