[a11y] Enable tab navigation over SessionList #2771
Conversation
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Codewise looks good to me... just one minor comment. I still approve so you can fix if you want and then go ahead without another review.
I did not try this myself - your screen capture seems to make sense.
| <p class="hint"> | ||
| {{ t('text', 'Author colors are only shown until everyone has closed the document.') }} | ||
| </p> | ||
| <form ref="form" tabindex="0" @submit.prevent> |
There was a problem hiding this comment.
I think we should rather put the initial focus on https://github.com/nextcloud/text/pull/2771/files#diff-9e0a2a342f91d6277778b1bb6b17da4f37cdab38ef53c98a7c97a84deaf488a5R40 so that the content gets read and maybe give this a descriptive label then
| <Popover class="session-list" | ||
| placement="bottom" | ||
| @after-show="applyFocus" | ||
| @after-hide="revertFocus"> |
There was a problem hiding this comment.
Maybe we can additionally catch tab/escape keys and prevent the default event handling and instead just revert the focus.
| this.$refs.form.focus() | ||
| }, | ||
| revertFocus() { | ||
| this.$editor.chain().focus().run() |
There was a problem hiding this comment.
Should this rather go back to focus on the button after closing?
There was a problem hiding this comment.
I don't know. But I am open for ideas.
|
@vinicius73 Any thoughts about using something like in nextcloud-libraries/nextcloud-vue#2654 ? Could also be fixed upstream globally then nextcloud-libraries/nextcloud-vue#2860 |
Looks interesting, I will play around this a bit. |
Signed-off-by: Vinicius Reis <[email protected]>
Co-authored-by: max-nextcloud <[email protected]> Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
|
Works like a charm @juliushaertl |
vinicius73
force-pushed
the
2733-bad-focus-order-for-collaborator-menu
branch
from
dd1c74d to
6fd13d0
Compare
|
Waiting for next release of |
Summary
Enable tab usage on session list popover.
Peek.2022-08-01.19-38.mp4
Peek.2022-08-01.19-39.mp4