-
Notifications
You must be signed in to change notification settings - Fork 96
add handle keyboard focus for accessibility #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05815d8 to
84f5487
Compare
10 tasks
PVince81
reviewed
Apr 25, 2022
bd24f12 to
d3aa803
Compare
PVince81
reviewed
Apr 25, 2022
d3aa803 to
8d7e163
Compare
skjnldsv
approved these changes
Apr 28, 2022
8d7e163 to
7538a61
Compare
artonge
reviewed
Apr 29, 2022
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.de>
7538a61 to
5717819
Compare
artonge
approved these changes
May 2, 2022
Contributor
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Contributor
|
Does it also work with multiple modals on top of each other e.g. like the text app uses? |
Contributor
Tested, works fine <template>
<div>
<button @click="modal = true">Show Modal</button>
<modal v-if="modal" @close="modal = false" size="small">
<div class="modal__content">Hello world</div>
<button @click="modal2 = true">Show Modal 2</button>
<modal v-if="modal2" @close="modal2 = false" size="small">
<div class="modal__content">Hello world 2</div>
</modal>
</modal>
</div>
</template>
<script>
export default {
data() {
return {
modal: false,
modal2: false
}
},
}
</script> |
This was referenced Jul 20, 2022
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
enhancement
New feature or request
feature: modal
Related to the modal component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add focus-trap (https://github.com/focus-trap/focus-trap) for accessibility
focus-trap.mp4
Signed-off-by: Vanessa Pertsch vanessa.pertsch@posteo.de