Add ability to set guest name in lobby

[marcoambrosini]

Signed-off-by: Marco Ambrosini [email protected]

[nickvergessen]

Feels a bit awkward that when you are typing your name and the lobby ends it is canceled.
But blocking the user from knowing the call started just because they opened the edit field is also weird.

[jancborchardt]

This was btw in the spec for the lobby ;) #1926 (comment)

• You can set your name already before you join the meeting.
  

[marcoambrosini]

Wow, that looks so different from what we have now... For the renaming I just copied the same component that we use in the sidebar for now, we did it together in January's contributor week @jancborchardt. Don't you think that it's better than the explicit input field??

[jancborchardt]

@ma12-co the idea was that if the name is the default "Guest", you probably want to change it and we can directly show the input field. It wouldn’t need to show as input field if you already set a name. My only suggestions for that:

• We should call it "Your name" instead of "Display name" as that’s quite technical
• The input field could replace the current name and the edit button in place, especially

Wow, that looks so different from what we have now...

Yeah – it’s rather bland at the moment. I’d still love for the mockup and spec to be followed a bit more:

• It looks much much better. We don’t necessarily need to have the dark background, but this standard blue header and the white content just looks so basic.
• Gives you feedback as to who you will be talking to – just like e.g. Hangouts does before joining
• Shows your own camera in case it’s a video call – also just like Hangouts
• Unclear what "waiting in the lobby" means. "Waiting for moderators to start the call" is clear and you know who to talk to if it does not start.
• Some other points in the spec as well – give it a read at ⏳ Lobby #1926 (comment)

[marcoambrosini]

Ok created an issue from your comment