-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👤 Ask Guest to enter a name when connecting #855
Comments
@jenniferpiperek what do you think design-wise? |
Having only "Guests" in the conversation can be really annoying. If a non authenticated user joins a conversation via public link (password protected or not). There should be a dialog in the center of the screen, where the user is forced to enter a name.
Edit: |
#855 (comment) But actually I would only force the user to enter a username if he wants to write something, because sometimes I don't want to write something in a public chat but only see what others have written there... |
A blocking, even soft-blockong modal in this case is a no-go. It introduces an unnecessary step, one we actually had at some point and removed again. How about this:
"Set your name" being linkified (primary color) and when clicked, opens sidebar with the name change input. Solves the issue nicely, gives feedback, and doesn't block anything. We only need to make sure it works well on mobile too. What do you think @ma12-co @nickvergessen? |
Let's not mess with the At least the lobby waiting screen (which is already blocking) can have a direct setting option. Maybe an adjusted placeholder is enough as a first step, maybe even an opened tooltip to draw more attention to the setting? |
Added to the lobby screen with #3133 So I'm closing this as per above |
If we do hide the right sidebar by default, and the lobby is not activated (which normally it is not), then this will still be an issue. So I’d still say we keep it open? What I proposed above will not mess with the contenteditable, but can insert a separate element floating a z-index above the input (or whichever way works). In any case – we should keep tracking this issue as it’s not solved for most cases. |
Since we will have actions in the AppContent, one of these actions could be 'change name'. And that indeed could bring up the mini modal! It's also very mobile friendly! |
You mean the 3-dot-menu? This is too hidden for changing your name, since as a guest you might not look in the menu before you start writing. What’s wrong with the subtle but clear message in the message input field as proposed above at #855 (comment) |
Nothing really, just a pain of a component to touch xD |
It would indeed be nice to show a proper modal here. Not only for putting in the guest name, but also for showing the conversation image and name as a quick "Welcome". Who is interested in making a mockup here @nextcloud/designers? :) |
I can do that :) |
Are we agreed, that a guest shall not continue using (reading, chating) in the joined conversation, until he'll submit a name? |
Yes, that was the idea. Didnt I make this clear with my mockup? |
No, that's clear from mockup, but not from the UX point of view, in my minds at least. We're forcing users to input something, and that will cover maybe 90-95% of users. |
That is why there is a placeholder guest. They could simply type in guest? |
I would actually like to not introduce an extra button for users that want to not change their name. Why should we make it easy for them to keep using guest when we instead want them to enter their name? |
I think, that returns us to 3-years-old discussion: #855 (comment) It's just my opinion, but still, it's better to see |
If a guest joins a conversation with a public link, ask him to enter a name.
I know you can change it here:
But i think the most won't do this... so why don't ask him when he connects.
The text was updated successfully, but these errors were encountered: