Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve silent message visibility #13806

Merged
merged 4 commits into from
Nov 20, 2024
Merged

fix: improve silent message visibility #13806

merged 4 commits into from
Nov 20, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 18, 2024 •
edited by Antreesy
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🏁 Checklist

@DorraJaouad DorraJaouad requested a review from Antreesy November 18, 2024 18:57
@DorraJaouad DorraJaouad self-assigned this Nov 18, 2024
@DorraJaouad DorraJaouad force-pushed the fix/12008/silent-message-ui branch from 629a4c9 to 3e334e7 Compare November 19, 2024 16:17
Antreesy
Antreesy approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/NewMessage/NewMessage.vue Outdated Show resolved Hide resolved
@DorraJaouad
fix: highlight silent toggle and keep showing it when it is active.
964cdc0 
maintain silentChat state across upload editor and main new message input

Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad
feat: show silent message icon in other people messages
6a2b4fa 
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad
feat: show silent message hint
84f9c74 
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad
fix: change the placeholder when silent message is on
5a96cce 
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad force-pushed the fix/12008/silent-message-ui branch from f13c36f to 5a96cce Compare November 20, 2024 13:25
@DorraJaouad
Copy link
Contributor Author

/backport to stable30

@DorraJaouad DorraJaouad merged commit 2b80faf into main Nov 20, 2024
47 checks passed
@DorraJaouad DorraJaouad deleted the fix/12008/silent-message-ui branch November 20, 2024 13:28
@backportbot backportbot bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
bug enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send without notification is not obvious enough
3 participants
@DorraJaouad @nickvergessen @Antreesy