Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TopBar): disable buttons if user has no media permissions #13168

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(TopBar): disable buttons if user has no media permissions #13168

merged 1 commit into from
Aug 28, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix false positively active buttons
    • audio/video buttons could opened MediaSettings before, but if you're not allowed to stream audio/video - nothing to change?

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before (cursor: pointer) 🏡 After (cursor: default)
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 28, 2024
@Antreesy Antreesy requested a review from DorraJaouad August 28, 2024 15:23
@Antreesy Antreesy self-assigned this Aug 28, 2024
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit 1c51bf5 into main Aug 28, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/disable-call-buttons branch August 28, 2024 17:11
@backportbot backportbot bot mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @ShGKme