Merge pull request #13168 from nextcloud/fix/noid/disable-call-buttons

fix(TopBar): disable buttons if user has no media permissions
nextcloud · Aug 28, 2024 · 1c51bf5 · 1c51bf5
2 parents 5e54f1c + 5676b8f
commit 1c51bf5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/components/CallView/shared/LocalAudioControlButton.vue b/src/components/CallView/shared/LocalAudioControlButton.vue
@@ -7,7 +7,8 @@
 	<NcButton v-tooltip="audioButtonTooltip"
 		:type="type"
 		:aria-label="audioButtonAriaLabel"
-		:class="{ 'no-audio-available': !isAudioAllowed || !model.attributes.audioAvailable }"
+		:class="{ 'no-audio-available': !model.attributes.audioAvailable }"
+		:disabled="!isAudioAllowed"
 		@click.stop="toggleAudio">
 		<template #icon>
 			<VolumeIndicator :audio-preview-available="model.attributes.audioAvailable"

diff --git a/src/components/CallView/shared/LocalVideoControlButton.vue b/src/components/CallView/shared/LocalVideoControlButton.vue
@@ -7,7 +7,8 @@
 	<NcButton v-tooltip="videoButtonTooltip"
 		:type="type"
 		:aria-label="videoButtonAriaLabel"
-		:class="{ 'no-video-available': !isVideoAllowed || !model.attributes.videoAvailable }"
+		:class="{ 'no-video-available': !model.attributes.videoAvailable }"
+		:disabled="!isVideoAllowed"
 		@click.stop="toggleVideo">
 		<template #icon>
 			<VideoIcon v-if="showVideoOn" :size="20" />

diff --git a/src/components/TopBar/TopBarMediaControls.vue b/src/components/TopBar/TopBarMediaControls.vue
@@ -73,6 +73,7 @@
 			class="app-navigation-entry-utils-menu-button"
 			:boundaries-element="boundaryElement"
 			:container="container"
+			:disabled="!isScreensharingAllowed"
 			:open.sync="screenSharingMenuOpen">
 			<template #icon>
 				<MonitorOff :size="20" />
@@ -95,6 +96,7 @@
 			v-tooltip="screenSharingButtonTooltip"
 			type="tertiary"
 			:aria-label="screenSharingButtonAriaLabel"
+			:disabled="!isScreensharingAllowed"
 			@click.stop="toggleScreenSharingMenu">
 			<template #icon>
 				<MonitorShare :size="20" />