Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theming): Change the talk hash on user theming change #11406

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(theming): Change the talk hash on user theming change #11406

merged 1 commit into from
Jan 19, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 19, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Jan 19, 2024
@nickvergessen nickvergessen self-assigned this Jan 19, 2024
Antreesy
Antreesy approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, changes also look fine.

I'm assuming, it works only for theme coloring change (like when change background)? Because I couldn't trigger it with light/dark switch

@nickvergessen nickvergessen force-pushed the bugfix/11386/change-talk-hash-on-theming branch from 3483c85 to 523567e Compare January 19, 2024 11:44
@nickvergessen nickvergessen merged commit 3fc00f1 into main Jan 19, 2024
53 checks passed
@nickvergessen nickvergessen deleted the bugfix/11386/change-talk-hash-on-theming branch January 19, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Include userCacheBuster in talkHash
2 participants
@nickvergessen @Antreesy