Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include userCacheBuster in talkHash #11386

Closed
SystemKeeper opened this issue Jan 15, 2024 · 0 comments · Fixed by #11406
Closed

Include userCacheBuster in talkHash #11386

SystemKeeper opened this issue Jan 15, 2024 · 0 comments · Fixed by #11406
Assignees
Labels
1. to develop enhancement feature: api 🛠️ OCS API for conversations, chats and participants good first issue
Milestone

Comments

@SystemKeeper
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently we only include the system cache buster value when we create our talk hash:

$this->config->getAppValue('theming', 'cachebuster', '1')

Describe the solution you'd like

When a user changes the theming settings, the hash does not get invalidated. Therefore clients might not refetch the server capabilities and update the theming. We might think about including the user cache buster as well:

https://github.com/nextcloud/server/blob/eaa6d96cf7d447c5b9db5fcb0657dad5bb9c88af/apps/theming/lib/Util.php#L339-L340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement feature: api 🛠️ OCS API for conversations, chats and participants good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants