[stable27] Fix lost audio track on safari #11145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Müller <[email protected]>
Antreesy
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Tested (Safari), seems to work (although I've caught a lost audio + frozen camera, then browser reconnected afterwards, so looks unrelated)
It is correct that we use
requirehere
As I know, it's better to not mix require and import in one file, so fine to be here like this.
nickvergessen
added
bug
feature: WebRTC 🚡
This was referenced Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is correct that we use
requirehere, since we are still using webpack and haven't moved to esm modules on stable27, right?🏁 Checklist
docs/has been updated or is not required