-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lost audio track on safari #11006
Conversation
46a09e9
to
b176cea
Compare
I see the way like this: we can split this mixin into utilities (common) and composable (to use in components) |
We need neither mixin nor composable here. This functionality has nothing Vue-related nor anything reactive. No chance that "a web-browser will be changed during a process" =D So we can make it an util. |
Maybe we could do that first and then rebase this PR on top of it? I would like to keep this PR as isolated as possible (Safari 😅...) |
I'll make a PR in 0.5h |
PR was closed by #11009 due to wrong comment. Reopening |
Needs a rebase now |
Will take care |
Signed-off-by: Marcel Müller <[email protected]>
b176cea
to
09360a8
Compare
Rebased on main. |
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
/backport to stable27 |
☑️ Resolves
After lots of manual trying, it looks like the safari bug was introduced between 12.0.0-alpha2 and 12.0.0-alpha3. After bisecting the commit abe5633 seems to be the problem. It belongs to the PR #5660 which replaces disabled tracks with a null track to reduce the amount of data being sent. Reverting the commit above makes the problem #6094 not reproducible anymore in safari.
I don't know if there's a way to use https://github.com/nextcloud/spreed/blob/main/src/mixins/browserCheck.js in
peer.js
as well, currently I just usedua-parser-js
directly.Based on the additional safari check, this should only effect safari and no other browsers.
🚧 Tasks
🏁 Checklist