Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Apps discover section #44129

Merged
merged 6 commits into from
Mar 14, 2024
Merged

feat: Apps discover section #44129

merged 6 commits into from
Mar 14, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 11, 2024 •
edited
Loading

Summary

vokoscreenNG-2024-03-12_16-40-31.mp4

TODO

  • Drop the test commit before merge ❗
  • (maybe follow up) Implement show case type (follow up)

Checklist

@AndyScherzinger AndyScherzinger mentioned this pull request Mar 12, 2024
Merged
@susnux susnux force-pushed the feat/discover-apps-section branch from abd6b12 to d03ab07 Compare March 12, 2024 17:56
@susnux susnux force-pushed the feat/discover-apps-section branch from d03ab07 to 0fbd4fe Compare March 13, 2024 01:49
@susnux susnux force-pushed the feat/discover-apps-section branch 2 times, most recently from ccca095 to e5992a7 Compare March 14, 2024 09:45
@susnux susnux added this to the Nextcloud 29 milestone Mar 14, 2024
@susnux susnux marked this pull request as ready for review March 14, 2024 09:47
@susnux susnux changed the title [wip] Apps discover section feat: Apps discover section Mar 14, 2024
@susnux susnux requested review from artonge, Pytal and emoral435 March 14, 2024 09:59
@susnux susnux mentioned this pull request Mar 14, 2024
Merged
Altahrim
Altahrim reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@Altahrim Altahrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments on PHP part

apps/settings/lib/Controller/AppSettingsController.php Outdated Show resolved Hide resolved
apps/settings/lib/Controller/AppSettingsController.php Outdated Show resolved Hide resolved
apps/settings/lib/Controller/AppSettingsController.php Outdated Show resolved Hide resolved
@susnux susnux requested a review from Altahrim March 14, 2024 14:30
@susnux susnux force-pushed the feat/discover-apps-section branch 2 times, most recently from 804a107 to 1c8ba07 Compare March 14, 2024 14:39
@susnux susnux force-pushed the feat/discover-apps-section branch from 1c8ba07 to 6b3e62e Compare March 14, 2024 16:41
skjnldsv
skjnldsv reviewed Mar 14, 2024
View reviewed changes
apps/settings/lib/Controller/AppSettingsController.php Outdated
Comment on lines 134 to 138
// $data = $this->discoverFetcher->get();

// TODO REMOVE JUST FOR TESTING
$file = file_get_contents(__DIR__ . '/../../discover.json');
$data = json_decode($file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, make sense! 👍

Pytal
Pytal approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor remarks ✅, did not test

lib/composer/composer/autoload_psr4.php Outdated Show resolved Hide resolved
lib/private/App/AppStore/Fetcher/AppDiscoverFetcher.php Show resolved Hide resolved
lib/private/App/AppStore/Fetcher/AppDiscoverFetcher.php Show resolved Hide resolved
apps/settings/src/components/AppStoreDiscover/CarouselType.vue Outdated Show resolved Hide resolved
apps/settings/src/components/AppStoreDiscover/CarouselType.vue Outdated Show resolved Hide resolved
@susnux susnux force-pushed the feat/discover-apps-section branch from 6b3e62e to 1ac9d62 Compare March 14, 2024 16:51
@susnux susnux force-pushed the feat/discover-apps-section branch from 1ac9d62 to 5adc667 Compare March 14, 2024 17:05
@susnux susnux force-pushed the feat/discover-apps-section branch from 5adc667 to f600ef6 Compare March 14, 2024 17:24
emoral435
emoral435 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local dev - looks really cool :) Small questions but overall - fantastic PR!

lib/private/App/AppStore/Fetcher/AppDiscoverFetcher.php Outdated Show resolved Hide resolved
lib/private/App/AppStore/Fetcher/AppDiscoverFetcher.php Outdated Show resolved Hide resolved
@susnux susnux force-pushed the feat/discover-apps-section branch from f600ef6 to c4d1d97 Compare March 14, 2024 17:41
@susnux susnux requested a review from skjnldsv March 14, 2024 17:42
@susnux susnux force-pushed the feat/discover-apps-section branch from c4d1d97 to 96f6907 Compare March 14, 2024 17:44
susnux added 6 commits March 14, 2024 20:45
@susnux @Altahrim
feat(settings): Implement new app discover section for app management
4cadb82 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @Altahrim
feat: Allow to fetch app discover json and provide frontend API route
f4efb76 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @Altahrim
feat(settings): Implement post type for app discover section
aa29204 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @Altahrim
feat(settings): Implement carousel type for app discover section
ac40038 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @Altahrim
feat(settings): Cache app discover images to ensure privacy of users
df502c1 
Co-authored-by: Benjamin Gaussorgues <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @Altahrim
chore: Compile assets
a61cef9 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@Altahrim Altahrim force-pushed the feat/discover-apps-section branch from 96f6907 to a61cef9 Compare March 14, 2024 19:45
@Altahrim
Copy link
Collaborator

Removed the test commit

@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2024
@Altahrim Altahrim enabled auto-merge March 14, 2024 20:08
@Altahrim Altahrim merged commit 74f996b into master Mar 14, 2024
167 checks passed
@Altahrim Altahrim deleted the feat/discover-apps-section branch March 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@emoral435 emoral435 emoral435 approved these changes

@artonge artonge Awaiting requested review from artonge

@Altahrim Altahrim Awaiting requested review from Altahrim

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: apps management feature: recommended apps 🍀 2024-Spring
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

🆕 Apps "Discover" section: Showcasing app ecosystem inside the app store
5 participants
@susnux @Altahrim @skjnldsv @Pytal @emoral435