Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: App discover schema #1313

Merged
merged 5 commits into from
Mar 14, 2024
Merged

fix: App discover schema #1313

merged 5 commits into from
Mar 14, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 12, 2024

Follow up on #1302 for nextcloud/server#42547

This fixes some issues found with the schema:

  1. Missing id
  2. Optional order
  3. Make localized values consistent (strings and media)
  4. Add support for source sets - required for videos.

@susnux susnux marked this pull request as ready for review March 13, 2024 16:11
@susnux susnux force-pushed the fix/discover-schema branch from cf7cb02 to 45162a2 Compare March 14, 2024 10:10
@susnux susnux merged commit 5c8cf95 into master Mar 14, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/discover-schema branch March 14, 2024 11:02
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants