Migrate header check to setupcheck API #44067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
come-nc
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
4 times, most recently
from
27eee79 to
225cf90
Compare
come-nc
added
3. to review
|
/compile / |
come-nc
requested review from
susnux,
a team,
ArtificialOwl,
icewind1991 and
Altahrim
and removed request for
a team
susnux
reviewed
Mar 12, 2024
| @@ -68,7 +68,7 @@ public function run(): SetupResult { | |||
| ]; | |||
|
|
|||
| foreach ($providers as $provider) { | |||
| foreach ($this->runHEAD($this->urlGenerator->getWebroot() . $provider) as $response) { | |||
There was a problem hiding this comment.
If that is removed, then drop also runHEAD function?
There was a problem hiding this comment.
Still used in other checks I think but yeah we could move all of them.
come-nc
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
1f7d36d to
dd211d0
Compare
|
/compile / |
Merged
Altahrim
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
If domain contains only one dot (xxxxx.yyy), we could also advise to use HSTS includeSubDomains and preload (https://hstspreload.org/)
susnux
approved these changes
Mar 13, 2024
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…ementation Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
susnux
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
7b00b81 to
99e967a
Compare
|
/compile amend |
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
99e967a to
58ae7e4
Compare
Merged
Signed-off-by: Côme Chilliet <[email protected]>
I do not have any knowledge about this, I’d say that would be a followup, let’s migrate the feature first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
Security related header check migrated to new API and done from backend now.
TODO:
Checklist