Bugfix/fix invisible logs #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotdrop
force-pushed
the
bugfix/fix-invisible-logs
branch
from
2681655 to
881d86e
Compare
rotdrop
force-pushed
the
bugfix/fix-invisible-logs
branch
from
881d86e to
7ff83bf
Compare
Closed
bencomp
reviewed
Aug 27, 2022
| <ReactCSSTransition | ||
| key={i} | ||
| classNames="highlight" | ||
| timeout={{ enter: 15000, exit: 1500 }} |
There was a problem hiding this comment.
As a sanity check (I don't know much about React): you add 15000 vs 1500, and below it was 1500 and 1500. Is that intended?
|
One of the actions failed, apparently because the package |
…p with react-transition-group Just tried to follow the migration guide: https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md This commit addresses the issue that the invisibl log-entries experienced with Nextcloud v24 are caused by pulling in conflicting version of react-dom. See issue nextcloud#699. Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop
force-pushed
the
bugfix/fix-invisible-logs
branch
from
7ff83bf to
22ad1b5
Compare
|
Thanks for the fix! I've cherry picked the relevant commit into a bigger PR (#821) to reduce the rebasing/conflict resolving needed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #699
This pull request just replaces react-addons-css-transition-group with react-transition-group, following the guide here:
https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md
For me this seems to fix #699.
Notes: I have problem with the package.json of the logreader pacakge, it specifies
However. to my knowledge node v14 comes with npm v6, while npm v7 comes only with node v15. But then we have here conflicting versions of the required engines. As the package-lock in the repo already is V2, I would suspect that the the node-version is just wrong.