Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error opening log in 24 #699

Closed
nickvergessen opened this issue Apr 20, 2022 · 12 comments · Fixed by #703
Closed

Error opening log in 24 #699

nickvergessen opened this issue Apr 20, 2022 · 12 comments · Fixed by #703

Comments

@nickvergessen
Copy link
Member

Steps to reproduce

  1. Open log in a 24 instance
  2. See log for some milliseconds
  3. See log disappearing

Expected behaviour

Log is visible

Actual behaviour

Error: Minified React error #188; visit https://reactjs.org/docs/error-decoder.html?invariant=188 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    findDOMNode React
    transition CSSTransitionGroupChild.js:129
    componentWillEnter CSSTransitionGroupChild.js:97
    performEnter TransitionGroup.js:83
    componentDidUpdate TransitionGroup.js:192
    componentDidUpdate TransitionGroup.js:191
    React 2
    unstable_runWithPriority scheduler.production.min.js:18
    React 4
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    mt App.js:160
    emit events.js:153
    e LogProvider.js:466
    c runtime.js:63
    _invoke runtime.js:294
    w runtime.js:119
    Babel 6
    value LogProvider.js:484
    e App.js:212
    c runtime.js:63
    _invoke runtime.js:294
    w runtime.js:119
    Babel 14
    value App.js:229
    React 2
    unstable_runWithPriority scheduler.production.min.js:18
    React 9
    _t index.js:17
    _t index.js:28
    <anonymous> index.js:23
    <anonymous> index.js:23
    <anonymous> index.js:23
react-dom.production.min.js:216:199
@nickvergessen
Copy link
Member Author

Still happening btw

@nickvergessen nickvergessen reopened this May 19, 2022
@arnowelzel
Copy link
Contributor

arnowelzel commented May 23, 2022

Also see #719 - the behaviour is similar but caused by log files which are too big.

@rotdrop
Copy link
Contributor

rotdrop commented May 24, 2022

From reading here

facebook/react#20131 pointing to https://reactjs.org/warnings/invalid-hook-call-warning.html

and running

 $ npm ls react-dom
logreader@ /var/www/localhost/htdocs/nextcloud-git-next/apps/logreader
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected]
└── [email protected]

I somehow got the impression that this might be caused by pulling in multiple copies of react-dom?

@CarlSchwan
Copy link
Member

We might want to replace this react addon's since it's dead https://www.npmjs.com/package/react-addons-css-transition-group

@nickvergessen
Copy link
Member Author

Or someone makes a greater journey and moves it to vue if that is better?

@Valdnet
Copy link
Contributor

Valdnet commented Jun 21, 2022

Any news?

The bug is a bit of a pain in the ass 😬.

rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Jun 28, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.
rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Jun 28, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.

Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Jun 28, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.
@wiswedel
Copy link

wiswedel commented Aug 1, 2022

still no logs in 24.0.3 :-(

@arnowelzel
Copy link
Contributor

The reason is the amount of log data. If you delete the old log data/nextcloud.log you should be able to see new log entries again. However if the file contains more than about 20.000 entries, the log viewer seems to get a problem.

@victoraroyo
Copy link

I too have this from a few nextcloud versions and I'm not so sure it is the 20000 entries limit/problem. Even with empty/clean log file mine does not shows. And the error in the console is the react one pointed above.

rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Aug 17, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.
rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Aug 17, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.

Signed-off-by: Claus-Justus Heine <[email protected]>
@rotdrop
Copy link
Contributor

rotdrop commented Aug 17, 2022

I too have this from a few nextcloud versions and I'm not so sure it is the 20000 entries limit/problem. Even with empty/clean log file mine does not shows. And the error in the console is the react one pointed above.

You could look at my merge request #746 and see whether it works for you. The bugfix just replaces the outdated react library with the current one and adjust the corresponding API calls in order to make it work. So this is a kind of minimal approach (no porting to Vue etc. attempted, just update the outdated react library).

@victoraroyo
Copy link

Thanks, I'm doing it now. After reading about this in react discussions I guess it will work. Hope this will be in next releases till waiting for vue solution.

rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Nov 9, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.

Signed-off-by: Claus-Justus Heine <[email protected]>
icewind1991 pushed a commit that referenced this issue Nov 24, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue #699.

Signed-off-by: Claus-Justus Heine <[email protected]>
icewind1991 pushed a commit that referenced this issue Nov 28, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue #699.

Signed-off-by: Claus-Justus Heine <[email protected]>
icewind1991 pushed a commit that referenced this issue Nov 28, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue #699.

Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Dec 14, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.
rotdrop added a commit to rotdrop/nextcloud-logreader that referenced this issue Dec 19, 2022
…p with react-transition-group

Just tried to follow the migration guide:

https://github.com/reactjs/react-transition-group/blob/HEAD/Migration.md

This commit addresses the issue that the invisibl log-entries
experienced with Nextcloud v24 are caused by pulling in conflicting
version of react-dom. See issue nextcloud#699.
@Antreesy
Copy link
Collaborator

Last version of Logreader written in react is Nextcloud 27.1.11 (End of life was at 2024-06-25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants