Add new section in settings for Nextcloud apps #2461

mpivchev · 2023-06-12T14:40:58Z

This adds a new section in settings to promote our other apps:

If the app is installed, it opens it without doing anything else.
- Note: Originally it was supposed to open the app and switch accounts (if account is logged in), but that is not supported by Talk or Notes yet. Separate issues have been made. See: Add other Nextcloud apps to settings as suggestions #2460. For now I suggest we do it this way and move this PR forward until we have the other issues done @tobiasKaminsky @jancborchardt
If the app is not installed, it leads to the app store page.
If the "more apps" icon is clicked, it opens a web page with other Nextcloud apps.

Additionally, a new URL scheme was made to add support for other apps to open this app and switch accounts (if account is logged in):

nextcloud://open-and-switch-account?user=someUser&url=https://cloud.nextcloud.com

Finally, refactored some of the code and removed duplicate code.

Signed-off-by: Milen Pivchev <[email protected]>

mpivchev · 2023-06-15T11:08:50Z

iOSClient/More/NCMore.swift

-class CCCellMore: UITableViewCell {
-
-    @IBOutlet weak var labelText: UILabel!
-    @IBOutlet weak var imageIcon: UIImageView!
-    @IBOutlet weak var separator: UIView!
-    @IBOutlet weak var separatorHeigth: NSLayoutConstraint!
-
-    override var frame: CGRect {
-        get {
-            return super.frame
-        }
-        set (newFrame) {
-            var frame = newFrame
-            let newWidth = frame.width * 0.90
-            let space = (frame.width - newWidth) / 2
-            frame.size.width = newWidth
-            frame.origin.x += space
-            super.frame = frame
-        }
-    }
-}
-
-class NCMoreUserCell: UITableViewCell {
-
-    @IBOutlet weak var displayName: UILabel!


These were separated in their own files

mpivchev · 2023-06-15T11:09:19Z

iOSClient/More/Cells/BaseNCMoreCell.swift

+class BaseNCMoreCell: UITableViewCell {
+    let selectionColor: UIView = UIView()
+    let defaultCornerRadius: CGFloat = 10.0
+
+    override var frame: CGRect {
+        get {
+            return super.frame
+        }
+        set (newFrame) {
+            var frame = newFrame
+            let newWidth = frame.width * 0.90
+            let space = (frame.width - newWidth) / 2
+            frame.size.width = newWidth
+            frame.origin.x += space
+            super.frame = frame
+        }
+    }
+
+    override func awakeFromNib() {
+        super.awakeFromNib()
+
+        selectedBackgroundView = selectionColor
+        backgroundColor = .secondarySystemGroupedBackground
+        layer.cornerRadius = defaultCornerRadius
+    }


This code was used for every cell, so I made a base class instead.

Signed-off-by: Milen Pivchev <[email protected]>

tobiasKaminsky · 2023-06-16T07:45:45Z

Can you use

https://github.com/nextcloud/desktop/blob/d8479fb1bafacbef2ecdb26516b9c7f513204f01/theme/white/more-apps.svg?plain=1

for more icon?

Signed-off-by: Milen Pivchev <[email protected]>

marinofaggiana · 2023-06-16T10:07:53Z

we could take the opportunity to migrate this simple view into swiftUI and the GUI does not convince me

mpivchev · 2023-06-16T13:25:19Z

we could take the opportunity to migrate this simple view into swiftUI and the GUI does not convince me

Hmm, we could've decided to do this earlier before these changes were made. But I can try nonetheless.

the GUI does not convince me

Any suggestions are welcome. We can maybe ask some of our UI designers to design a view.

marinofaggiana · 2023-06-18T09:20:23Z

we could take the opportunity to migrate this simple view into swiftUI and the GUI does not convince me

Hmm, we could've decided to do this earlier before these changes were made. But I can try nonetheless.

was only a consideration.

the GUI does not convince me

Any suggestions are welcome. We can maybe ask some of our UI designers to design a view.

I have to think about it.

jancborchardt

Nice! Design-wise, how about something standard like Apple also uses on the top of Contacts? That has proper spacing and all.

mpivchev · 2023-06-21T16:20:46Z

@jancborchardt you mean this part?

Since we only have 3 of these, should they be stacked left or be centered?

marinofaggiana · 2023-06-21T16:33:42Z

Haha I am on holiday and had saved this

marcoambrosini

I don't think that these shortcuts should be the first entry in the settings because they can be detrimental to usability and create friction. I would say that settings is probably the wrong place to advertise the presence of other apps, and I suggest something subtler and "dismissable". if we absolutely have to, what about moving them to the bottom of the list?

mpivchev · 2023-06-22T08:02:51Z

I don't think that these shortcuts should be the first entry in the settings because they can be detrimental to usability and create friction. I would say that settings is probably the wrong place to advertise the presence of other apps, and I suggest something subtler and "dismissable". if we absolutely have to, what about moving them to the bottom of the list?

I see your point. I still need to move this forward however, so if @jancborchardt is ok with this I can move this section to the bottom.

jancborchardt · 2023-06-22T09:08:57Z

Since we only have 3 of these, should they be stacked left or be centered?

@mpivchev is there any recommended default or standard? Centered seems good.

@marcoambrosini the issue if they are on the bottom is that they will be difficult to discover, defeating the purpose. It is obvious that the vertical list of entries goes on, but it would not be obvious that there is an entirely new element below.

Signed-off-by: Milen Pivchev <[email protected]>

mpivchev · 2023-06-22T10:16:34Z

@jancborchardt Here is the new look:

jancborchardt · 2023-06-22T10:30:14Z

In iOS Contacts, there is a bit more top and bottom padding inside the entries. Can you adjust that @mpivchev? :)

mpivchev · 2023-06-22T14:10:38Z

@jancborchardt Is this better?

Signed-off-by: Milen Pivchev <[email protected]>

…add-other-nextcloud-apps-to-settings-as-suggestions Signed-off-by: Milen Pivchev <[email protected]> # Conflicts: # Nextcloud.xcodeproj/project.pbxproj # iOSClient/NCGlobal.swift

Signed-off-by: Milen Pivchev <[email protected]>

codecov · 2023-06-22T14:55:33Z

Codecov Report

Patch coverage: 0.98% and project coverage change: -0.20 ⚠️

Comparison is base (422440e) 9.03% compared to head (d604a3c) 8.84%.

❗ Current head d604a3c differs from pull request most recent head 9f54ed4. Consider uploading reports for the commit 9f54ed4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #2461      +/-   ##
==========================================
- Coverage     9.03%   8.84%   -0.20%     
==========================================
  Files          185     188       +3     
  Lines        25747   25799      +52     
  Branches      9501    9529      +28     
==========================================
- Hits          2326    2281      -45     
- Misses       23217   23324     +107     
+ Partials       204     194      -10

Impacted Files	Coverage Δ
iOSClient/AppDelegate.swift	`29.72% <0.00%> (-0.39%)`	⬇️
iOSClient/More/Cells/BaseNCMoreCell.swift	`0.00% <0.00%> (ø)`
...OSClient/More/Cells/NCMoreAppSuggestionsCell.swift	`0.00% <0.00%> (ø)`
iOSClient/More/Cells/NCMoreUserCell.swift	`0.00% <0.00%> (ø)`
iOSClient/NCGlobal.swift	`32.25% <ø> (ø)`
iOSClient/More/NCMore.swift	`2.21% <2.17%> (+0.34%)`	⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mpivchev · 2023-06-23T16:11:11Z

@jancborchardt pinging again in case you missed it

jancborchardt

Latest screenshot looks good! :)

hannesfritz · 2023-06-30T15:51:11Z

iOS seems to stretch those buttons if less are available. I just found an example with 4 instead of 5 like in the screenshot above. But I did an additional mockup to show what it might look with only the three options.
In my opinion it is calmer on the eye, better aligned and additionally larger tap targets.

So just food for thought :)

jancborchardt · 2023-06-30T16:05:08Z

Yeah, that seems very nice @hannesfritz!

@mpivchev could you adjust them like that? :)

mpivchev · 2023-07-05T12:20:11Z

Branch restored so I can reimplement this soon

Add new section in settings

b3f75f7

Signed-off-by: Milen Pivchev <[email protected]>

This was linked to issues Jun 13, 2023

Tighter integration on apps within Nextcloud ecosystem nextcloud/files-clients#10

Closed

Add other Nextcloud apps to settings as suggestions #2460

Closed

mpivchev removed a link to an issue Jun 13, 2023

Tighter integration on apps within Nextcloud ecosystem nextcloud/files-clients#10

Closed

2 tasks

mpivchev added 2 commits June 13, 2023 12:18

WIP

dbf46a7

Signed-off-by: Milen Pivchev <[email protected]>

WIP

643dc44

Signed-off-by: Milen Pivchev <[email protected]>

mpivchev mentioned this pull request Jun 15, 2023

Add other Nextcloud apps to settings as suggestions #2460

Closed

4 tasks

mpivchev added 2 commits June 15, 2023 12:29

Add new cell/refactor

ce9347b

Signed-off-by: Milen Pivchev <[email protected]>

Add url scheme for switching account

f87cbf3

Signed-off-by: Milen Pivchev <[email protected]>

mpivchev commented Jun 15, 2023

View reviewed changes

mpivchev marked this pull request as ready for review June 15, 2023 11:09

mpivchev requested review from marinofaggiana and tobiasKaminsky June 15, 2023 11:09

Add docs

530df0c

Signed-off-by: Milen Pivchev <[email protected]>

mpivchev requested a review from jancborchardt June 15, 2023 11:13

Change icon

8c18976

Signed-off-by: Milen Pivchev <[email protected]>

marinofaggiana requested review from tobiasKaminsky and removed request for tobiasKaminsky June 18, 2023 09:20

jancborchardt requested changes Jun 21, 2023

View reviewed changes

mpivchev requested a review from jancborchardt June 21, 2023 18:01

marcoambrosini reviewed Jun 22, 2023

View reviewed changes

Add colors

480190e

Signed-off-by: Milen Pivchev <[email protected]>

mpivchev added 5 commits June 22, 2023 16:12

Add more padding

eeb84c3

Signed-off-by: Milen Pivchev <[email protected]>

Remove hardcoded urls

5965eda

Signed-off-by: Milen Pivchev <[email protected]>

Merge branch 'develop' of https://github.com/nextcloud/ios into 2460-…

05850ff

…add-other-nextcloud-apps-to-settings-as-suggestions Signed-off-by: Milen Pivchev <[email protected]> # Conflicts: # Nextcloud.xcodeproj/project.pbxproj # iOSClient/NCGlobal.swift

Refactor

045ae5a

Signed-off-by: Milen Pivchev <[email protected]>

Remove unused files

0e27b5d

Signed-off-by: Milen Pivchev <[email protected]>

Update lint

9f54ed4

mpivchev requested a review from marcoambrosini June 26, 2023 08:20

jancborchardt approved these changes Jun 26, 2023

View reviewed changes

mpivchev merged commit e66bcd6 into develop Jun 26, 2023

delete-merged-branch bot deleted the 2460-add-other-nextcloud-apps-to-settings-as-suggestions branch June 26, 2023 10:22

mpivchev restored the 2460-add-other-nextcloud-apps-to-settings-as-suggestions branch July 5, 2023 12:19

SystemKeeper mentioned this pull request May 2, 2024

Tighter integration on apps within Nextcloud ecosystem nextcloud/talk-ios#1327

Open

Uh oh!

Add new section in settings for Nextcloud apps #2461

Add new section in settings for Nextcloud apps #2461

Conversation

mpivchev commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpivchev Jun 15, 2023

Choose a reason for hiding this comment

Uh oh!

mpivchev Jun 15, 2023

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marinofaggiana commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpivchev commented Jun 16, 2023

Uh oh!

marinofaggiana commented Jun 18, 2023

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

mpivchev commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marinofaggiana commented Jun 21, 2023

Uh oh!

marcoambrosini left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mpivchev commented Jun 22, 2023

Uh oh!

jancborchardt commented Jun 22, 2023

Uh oh!

mpivchev commented Jun 22, 2023

Uh oh!

jancborchardt commented Jun 22, 2023

Uh oh!

mpivchev commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mpivchev commented Jun 23, 2023

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

hannesfritz commented Jun 30, 2023

Uh oh!

jancborchardt commented Jun 30, 2023

Uh oh!

mpivchev commented Jul 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mpivchev commented Jun 12, 2023 •

edited

Loading

tobiasKaminsky commented Jun 16, 2023 •

edited

Loading

marinofaggiana commented Jun 16, 2023 •

edited

Loading

mpivchev commented Jun 21, 2023 •

edited

Loading

marcoambrosini left a comment •

edited

Loading

mpivchev commented Jun 22, 2023 •

edited

Loading

codecov bot commented Jun 22, 2023 •

edited

Loading