fix: Remove legacy optimization when checking encryption status #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/fix/remove_legacy_optimization
branch
from
de89a50 to
56993c2
Compare
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy. Also, this seems unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer. Partially introduced by #316 which was an improvement at the time by introducing caching. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/remove_legacy_optimization
branch
from
56993c2 to
f5c5a93
Compare
artonge
added
3. to review
come-nc
approved these changes
Jan 16, 2025
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/868/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f5c5a936
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/868/stable30Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy.
Also, this seems unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer.
Partially introduced by #316 which was an improvement at the time by introducing caching.
Client marking sub folders as encrypted: