Cache end to end encrypted paths #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
ArtificialOwl,
icewind1991 and
skjnldsv
and removed request for
a team
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
cache-is-encrypted
branch
from
b859e5d to
b8b9c93
Compare
PVince81
reviewed
Aug 17, 2022
PVince81
reviewed
Aug 17, 2022
PVince81
reviewed
Aug 17, 2022
CarlSchwan
force-pushed
the
cache-is-encrypted
branch
4 times, most recently
from
51808b2 to
0e5f688
Compare
CarlSchwan
force-pushed
the
cache-is-encrypted
branch
3 times, most recently
from
ca81323 to
3d1f58c
Compare
PVince81
reviewed
Aug 23, 2022
come-nc
reviewed
Aug 23, 2022
come-nc
reviewed
Aug 23, 2022
CarlSchwan
force-pushed
the
cache-is-encrypted
branch
2 times, most recently
from
d1c1897 to
0ebdcad
Compare
Signed-off-by: Carl Schwan <[email protected]>
come-nc
approved these changes
Aug 23, 2022
CarlSchwan
force-pushed
the
cache-is-encrypted
branch
from
0ebdcad to
d135794
Compare
- Don't fetch OCP\Files nodes each time but instead use the one in $davNode->getNode() Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
cache-is-encrypted
branch
from
d135794 to
23deafa
Compare
artonge
added a commit
that referenced
this pull request
Jan 16, 2025
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy. Also, this seem unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer. Partially introduced by #316 which was an improvement at the time by introducing caching. Signed-off-by: Louis Chemineau <[email protected]>
3 tasks
artonge
added a commit
that referenced
this pull request
Jan 16, 2025
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy. Also, this seems unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer. Partially introduced by #316 which was an improvement at the time by introducing caching. Signed-off-by: Louis Chemineau <[email protected]>
artonge
added a commit
that referenced
this pull request
Jan 16, 2025
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy. Also, this seems unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer. Partially introduced by #316 which was an improvement at the time by introducing caching. Signed-off-by: Louis Chemineau <[email protected]>
artonge
added a commit
that referenced
this pull request
Jan 20, 2025
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy. Also, this seems unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer. Partially introduced by #316 which was an improvement at the time by introducing caching. Signed-off-by: Louis Chemineau <[email protected]>
artonge
added a commit
that referenced
this pull request
Jan 20, 2025
This is causing performance issues because for non encrypted nodes, we were checking all upper folders in the hierarchy. Also, this seems unnecessary as top and sub E2EE folders are marked as encrypted, so checking for the current node or its parent folder is enough to have the answer. Partially introduced by #316 which was an improvement at the time by introducing caching. Signed-off-by: Louis Chemineau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On perftesting this changes the DB requests to determine if a path is end to encrypted from ~900 to 72 with nextcloud/server#33602. Code is inspired by the filesystem tag checks in the workflowengine app.
Todos: