-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pdf+other image preview support to alpine images after Alpine's packaging change #2248
Add pdf+other image preview support to alpine images after Alpine's packaging change #2248
Conversation
Per https://git.alpinelinux.org/aports/commit/community/imagemagick/imagemagick.post-upgrade?h=3.19-stable&id=61dce5f6a84d9f96ab7aa6437f12d2845b572ed8 these are our options:
Looking at the formats supported in our Debian images, looks like we do all of these except for
Yeah. :-/ Up to you whether to combine them or not. Doesn't matter either way on this side now. |
Sure, I'll add the other formats you listed 👍 -except for jxl (what even is jxl 🤷 ).
I'll leave em' separate for now. |
…the alpine docker image Signed-off-by: jessebot <[email protected]>
0b66ab4
to
437a2e0
Compare
I had the exact same reaction. 😆 |
Ah, crap. It thinks there's a conflict now due to the one line change from the svg PR since that just got merged. 😜 Can you resolve however you prefer and then let's get this one in too. |
Signed-off-by: JesseBot <[email protected]>
No problem, that's what I get for not combining the PRs haha :) Let me know if you need anything else! |
Wow, all tests passed without having to kick them a few times to re-run. That's rare, but I'll take it! |
Amazing, and I agree very rare 😁 |
I'm also creating this PR to add PDF preview support, which doesn't work without the
imagemagick-pdf
package. This is in reference to #2246 (comment):We could also combine this PR with #2246 since we missed the release for
29.0.3
this time anyway. Open to either way, or if I misunderstood, please feel free to give me gentle feedback and I'll remedy what's needed! 🙏Also open to adding additional packages.
svg
andpdf
are just the file formats that stuck out to me from the beginning.