Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imagemagick-svg *back* to all the alpine images #2246

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

jessebot
Copy link
Contributor

@jessebot jessebot commented Jun 25, 2024

(Context: Alpine changed their imagemagick packaging)

This is an alternative to #2220 to move it forward. Followed the instructions per this comment: #2220 (review)

I can do another PR for imagemagick-pdf as well if you want, but to keep this short and simple, I've only done svg here, as that's the only one that throws a warning.

@joshtrichards
Copy link
Member

I can do another PR for imagemagick-pdf as well if you want, but to keep this short and simple, I've only done svg here, as that's the only one that throws a warning.

👍 Thank! Let's get this in since it's the most pressing with 29.0.3 right around the immediate corner.

But let's also create an issue now (or, better yet, WIP PR) to propose & firm up what others should also be added back in, in a follow-up[1].

[1] We probably want to keep parity. Is there anything that doesn't belong or should we just load all of them back in to mirror the old packaging?

Cc: @felix-egli

@joshtrichards joshtrichards added this to the Nextcloud 29.0.3 milestone Jun 26, 2024
@joshtrichards joshtrichards requested a review from J0WI June 26, 2024 02:56
@joshtrichards joshtrichards changed the title add imagemagick-svg to all the alpine images add imagemagick-svg *back* to all the alpine images Jun 26, 2024
@jessebot
Copy link
Contributor Author

@joshtrichards unless I misunderstood, I think this is what we wanted to do next for adding pdf support:
#2248

@jessebot
Copy link
Contributor Author

@J0WI and/or @joshtrichards is there anything we can do to ensure this gets into the next release?

@joshtrichards joshtrichards added image: alpine Alpine image specific bug labels Jun 28, 2024
@joshtrichards joshtrichards merged commit 747a3f8 into nextcloud:master Jun 28, 2024
16 of 21 checks passed
@jessebot jessebot deleted the add-imagemagick-svg branch June 29, 2024 05:48
@jessebot
Copy link
Contributor Author

jessebot commented Jun 29, 2024

Thanks for getting this over the line! I know this is a community maintained docker repo and everyone is doing their best! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants