Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QML 5.12 everywhere. #4119

Closed
wants to merge 2 commits into from
Closed

Use QML 5.12 everywhere. #4119

wants to merge 2 commits into from

Conversation

allexzander
Copy link
Contributor

Signed-off-by: alex-z [email protected]

This will fix #4069 and #4017

mgallien
mgallien requested changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not merge it as we require Qt 5.15 in our CMakeLists.txt files
thanks for the work, I am going to suggest packagers to use it

@mgallien
Copy link
Collaborator

mgallien commented Jan 3, 2022

@ivaradi Feel free to apply this PR to your Focal packaging branch
that should solve the issues with the main dialog not showing up

@allexzander
Copy link
Contributor Author

/rebase

@nextcloud-command nextcloud-command force-pushed the bugfix/qml-5.12-everywhere branch from 0dc83f5 to 791e418 Compare January 5, 2022 14:10
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4119-791e418f04a1a74e704f0471e6410d365b6ad02f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@allexzander
Copy link
Contributor Author

@mgallien Seems to have worked (see last commit)

mgallien
mgallien requested changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is broken on Qt 5.12.10

@allexzander allexzander deleted the bugfix/qml-5.12-everywhere branch August 1, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien requested changes

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Main dialog window does not open - Ubuntu
4 participants
@allexzander @mgallien @nextcloud-desktop-bot @claucambra