Skip to content

Revert Nextcloud core's contentedibtale styles #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 4 commits into from
Mar 12, 2022
Merged

Revert Nextcloud core's contentedibtale styles #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3a88aa
Revert Nextcloud core's contentedibtale styles
MarcelRobitaille Mar 8, 2022
6389acd
Also revert NC core styles for inputs
MarcelRobitaille Mar 12, 2022
ad80c49
Make code styling happy
christianlupus Mar 12, 2022
e64b811
Added changelog entry
christianlupus Mar 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
### Fixed
- Reduce complex coupling between event handlers in EditInputGroup.vue
[#901](https://github.com/nextcloud/cookbook/pull/901) @MarcelRobitaille
- Fix bug in NC Vue config that switches input fields to be not full width on mobile
[#910](https://github.com/nextcloud/cookbook/pull/910) @MarcelRobitaille

### Documentation
- Introduction about how to start coding
Expand Down
21 changes: 21 additions & 0 deletions src/components/EditInputField.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ fieldset > label {

fieldset > input,
fieldset > textarea {
width: revert;
flex: 1;
}

Expand All @@ -225,4 +226,24 @@ fieldset > .editor {
border-radius: 2px;
resize: vertical;
}

/*
Hack to overwrite the heavy-handed global unscoped styles of Nextcloud core
that cause our markdown editor CodeMirror to behave strangely on mobile
See: https://github.com/nextcloud/cookbook/issues/908

Use /deep/ because >>> did not work for some reason
*/
.editor /deep/ div[contenteditable="true"] {
width: revert;
min-height: revert;
padding: revert;
border: revert;
margin: revert;
background-color: revert;
border-radius: revert;
color: revert;
font-size: revert;
outline: revert;
}
</style>