Revert Nextcloud core's contentedibtale styles #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nextcloud core is setting global unscoped styles on any `div[contentedibtale]`. Such a div is used by our markdown editor: CodeMirror. Fix this by overwritting Nextcloud core's heavy-handed global styles. Signed-off-by: Marcel Robitaille <[email protected]>
Collaborator
|
Good catch! Just tested this directly on my phone and works as expected :) @MarcelRobitaille What do you think about the width of the Name and URL fields? Should we make them 100% on mobile as well? |
Collaborator
Author
|
@seyfeb thanks for checking the PR.
I think it would be consistent. I will try to add that too. |
Ensure that the name and URL fields of the recipe edit form are still full width on mobile. Overwrite Nextcloud core's heavy-handed global styles. Signed-off-by: Marcel Robitaille <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 20.08% 20.09% +0.01%
==========================================
Files 20 20
Lines 1434 1438 +4
==========================================
+ Hits 288 289 +1
- Misses 1146 1149 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908
Nextcloud core is setting global unscoped styles on any
div[contentedibtale]. Such a div is used by our markdown editor:CodeMirror. Fix this by overwritting Nextcloud core's heavy-handed global styles.
Now, adding
contenteditable="true"does not change the style inside our markdown editor:Peek.2022-03-08.14-48.mp4