Skip to content

Conversation

@jotoeri
Copy link
Member

@jotoeri jotoeri commented Oct 11, 2021

Adds a small part, that got lost in #797. Recipes without Category can have "recipeCategory":"", which means $json['recipeCategory'] is set, but there is no proper Category.

Fixes #802 🙂

@jotoeri jotoeri added bug Something isn't working Backend Issue or PR related to the backend code labels Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #805 (736f99c) into master (d59e1f6) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #805   +/-   ##
=========================================
  Coverage     21.76%   21.76%           
- Complexity      461      462    +1     
=========================================
  Files            20       20           
  Lines          1493     1493           
=========================================
  Hits            325      325           
  Misses         1168     1168           
Flag Coverage Δ
integration 7.23% <0.00%> (ø)
unittests 14.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Service/DbCacheService.php 0.00% <0.00%> (ø)

Signed-off-by: Jonas Rittershofer <[email protected]>
@jotoeri jotoeri force-pushed the fix/empty_category branch from 22a58fd to 736f99c Compare October 11, 2021 20:36
@github-actions
Copy link

github-actions bot commented Oct 11, 2021

Unit Test Results

  20 files  ±0    20 suites  ±0   7m 41s ⏱️ ±0s
  66 tests ±0    66 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
660 runs  ±0  660 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 31e4736. ± Comparison against base commit 31e4736.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus merged commit 31e4736 into master Oct 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/empty_category branch October 15, 2021 05:01
@eburger01
Copy link

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Issue or PR related to the backend code bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not choosing a category from the list should not create an empty category

4 participants