Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Closes #789

@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #797 (ca8c247) into master (91ee0ff) will decrease coverage by 0.14%.
The diff coverage is 6.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #797      +/-   ##
============================================
- Coverage     21.91%   21.76%   -0.15%     
- Complexity      458      461       +3     
============================================
  Files            20       20              
  Lines          1483     1493      +10     
============================================
  Hits            325      325              
- Misses         1158     1168      +10     
Flag Coverage Δ
integration 7.23% <0.00%> (-0.05%) ⬇️
unittests 14.53% <6.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Service/DbCacheService.php 0.00% <0.00%> (ø)
lib/Controller/MainController.php 100.00% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Sep 26, 2021

Unit Test Results

  20 files  ±0    20 suites  ±0   7m 51s ⏱️ ±0s
  66 tests ±0    66 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
660 runs  ±0  660 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 295aa63. ± Comparison against base commit 295aa63.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit 295aa63 into master Sep 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/789-trim-in-db-cache-service branch September 26, 2021 17:53
@jotoeri jotoeri mentioned this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php trim() error - very slow loading of app

2 participants