Skip to content

Fix deprecation of variable expansion #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 2 commits into from
May 20, 2024
Merged

Fix deprecation of variable expansion #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a99b095
Fix deprecation
christianlupus May 20, 2024
add0007
Update Changelog
christianlupus May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/current/2321-deprecation-warning-in-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Maintenance

- Remove deprecated PHP style from test code
12 changes: 6 additions & 6 deletions tests/Unit/Helper/FileSystem/RecipeNameHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ public function dpGetFolderName() {

return [
'short name' => ['recipe name', 'recipe name'],
'95 chars' => ["${ninetyChars}12345", "${ninetyChars}12345"],
'99 chars' => ["${ninetyChars}123456789", "${ninetyChars}123456789"],
'100 chars' => ["${ninetyChars}1234567890", "${ninetyChars}1234567890"],
'101 chars' => ["${ninetyChars}12345678901", "${ninetyChars}1234567..."],
'102 chars' => ["${ninetyChars}123456789012", "${ninetyChars}1234567..."],
'105 chars' => ["${ninetyChars}123456789012345", "${ninetyChars}1234567..."],
'95 chars' => ["{$ninetyChars}12345", "{$ninetyChars}12345"],
'99 chars' => ["{$ninetyChars}123456789", "{$ninetyChars}123456789"],
'100 chars' => ["{$ninetyChars}1234567890", "{$ninetyChars}1234567890"],
'101 chars' => ["{$ninetyChars}12345678901", "{$ninetyChars}1234567..."],
'102 chars' => ["{$ninetyChars}123456789012", "{$ninetyChars}1234567..."],
'105 chars' => ["{$ninetyChars}123456789012345", "{$ninetyChars}1234567..."],
'special chars' => ['a/b:c?d!e"f|g\\h\'i^j&k#l', 'a_b_c_d_e_f_g_h_i_j_k_l'],
];
}
Expand Down