Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Topic and Scope

The variable expansion in the form of "${varName}" in PHP is deprecated. Instead, one uses "{$varName}". The tests have the old syntax and should be fixed.

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus marked this pull request as ready for review May 20, 2024 13:53
@christianlupus christianlupus enabled auto-merge May 20, 2024 13:54
@github-actions
Copy link

Test Results

   12 files    572 suites   1m 32s ⏱️
  552 tests   552 ✅ 0 💤 0 ❌
2 208 runs  2 207 ✅ 1 💤 0 ❌

Results for commit add0007.

@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 824f416 into master May 20, 2024
@christianlupus christianlupus deleted the maintenance/deprecated-variable-expansion branch May 20, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants