Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2464): exclude contact from birthday calendar #3009

Merged
merged 1 commit into from
Oct 11, 2022
Merged

feat(2464): exclude contact from birthday calendar #3009

merged 1 commit into from
Oct 11, 2022

Conversation

sylvainmetayer
Copy link
Contributor

This should close #2464

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 31.40% // Head: 67.96% // Increases project coverage by +36.56% 🎉

Coverage data is based on head (ec8fb30) compared to base (4575f44).
Patch has no changes to coverable lines.

❗ Current head ec8fb30 differs from pull request most recent head e9730d6. Consider uploading reports for the commit e9730d6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3009       +/-   ##
=============================================
+ Coverage     31.40%   67.96%   +36.56%     
  Complexity      253      253               
=============================================
  Files           110       23       -87     
  Lines          1863      721     -1142     
  Branches        218        0      -218     
=============================================
- Hits            585      490       -95     
+ Misses         1163      231      -932     
+ Partials        115        0      -115     
Impacted Files Coverage Δ
.../components/AppNavigation/CircleNavigationItem.vue
...c/components/AppNavigation/GroupNavigationItem.vue
src/components/AppNavigation/RootNavigation.vue
src/components/ContactDetails.vue
...components/ContactDetails/ContactDetailsAvatar.vue
src/components/ContactsList.vue
src/components/ContactsList/ContactsListItem.vue
src/components/EntityPicker/EntityPicker.vue
src/mixins/CopyToClipboardMixin.js
src/views/Contacts.vue
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvainmetayer
Copy link
Contributor Author

Is there any tests I can do on this one for the frontend ?

I'm trying to run tests locally for the server side to validate what I've pushed is valid, but for the contacts side, I haven't find much resources and don't know how I could test my code.

@sylvainmetayer sylvainmetayer marked this pull request as ready for review October 3, 2022 10:21
@sylvainmetayer
Copy link
Contributor Author

Hi, @miaulalala or @tcitworld, could one of you please point me to some directions on how to tests this PR for the frontend part, if tests are mandatory for this to be merged ?

@szaimen szaimen added the 3. to review Waiting for reviews label Oct 6, 2022
@szaimen szaimen requested a review from st3iny October 6, 2022 21:16
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks a lot for your contribution.

The button needs a version check because the server PR will only be working from 26 onwards.

Example:

parseInt(OC.config.version.split('.')[0]) >= 26

And then toggle it via v-if.

@sylvainmetayer
Copy link
Contributor Author

I added a version check on the button as requested

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thanks again for your contribution :)

There is one minor issue with the wording but otherwise we are good to go.

src/components/ContactDetails.vue Outdated Show resolved Hide resolved
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One last thing I totally forgot in my last review: Please squash all commits into one before the merge. I'm sorry for all the nitpicking. This will be my last request 🙈

Signed-off-by: Sylvain <[email protected]>
Co-authored-by: Thomas Citharel <[email protected]>
Co-authored-by: Richard Steinmetz <[email protected]>
@sylvainmetayer
Copy link
Contributor Author

I've squashed all commits into a single one, the history should be better now :)

@st3iny st3iny merged commit 68b15a3 into nextcloud:main Oct 11, 2022
@welcome
Copy link

welcome bot commented Oct 11, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@sylvainmetayer sylvainmetayer deleted the feat_2464_exclude_contact_from_birthday_calendar branch October 11, 2022 11:28
@st3iny st3iny added this to the v5.1.0 milestone Apr 28, 2023
@st3iny st3iny added the enhancement New feature or request label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude Contacts from Birthday-Calendar
4 participants