Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simple editor size and jumping #6643

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 21, 2025

fixes #6630

this pr fixes 2 issues, the popover jumping and the description being smaller when you start typing

Screencast.from.2025-01-21.16-35-28.mp4

@GretaD GretaD self-assigned this Jan 21, 2025
@GretaD GretaD added 3. to review Waiting for reviews 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 21, 2025
@GretaD GretaD marked this pull request as ready for review January 21, 2025 15:12
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 21, 2025
@GretaD GretaD requested a review from nimishavijay January 21, 2025 15:13
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 22.97%. Comparing base (cad954e) to head (11f766f).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/Properties/PropertyText.vue 0.00% 5 Missing ⚠️
...ents/Editor/Properties/PropertyTitleTimePicker.vue 0.00% 2 Missing ⚠️
src/views/EditSimple.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6643   +/-   ##
=========================================
  Coverage     22.97%   22.97%           
  Complexity      475      475           
=========================================
  Files           252      252           
  Lines         12128    12128           
  Branches       2317     2318    +1     
=========================================
  Hits           2786     2786           
  Misses         9015     9015           
  Partials        327      327           
Flag Coverage Δ
javascript 14.51% <0.00%> (ø)
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD force-pushed the fix/simple-editor-improvements branch from d02ded1 to 11f766f Compare January 22, 2025 17:00
@GretaD GretaD enabled auto-merge January 22, 2025 17:01
@GretaD GretaD merged commit 096c678 into main Jan 22, 2025
37 of 38 checks passed
@GretaD GretaD deleted the fix/simple-editor-improvements branch January 22, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit simple is very unstable because of different widths and having dynamic fields
2 participants