Skip to content

Commit

Permalink
fix: simple editor size and jumping
Browse files Browse the repository at this point in the history
Signed-off-by: greta <[email protected]>
  • Loading branch information
GretaD committed Jan 22, 2025
1 parent d30e56a commit 11f766f
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 2 deletions.
13 changes: 13 additions & 0 deletions src/components/Editor/Properties/PropertyText.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
:rows="rows"
:name="readableName"
:value="value"
:class="{ 'textarea--description': isDescription }"

Check warning on line 24 in src/components/Editor/Properties/PropertyText.vue

View check run for this annotation

Codecov / codecov/patch

src/components/Editor/Properties/PropertyText.vue#L24

Added line #L24 was not covered by tests
@focus="handleToggleTextareaFocus(true)"
@blur="handleToggleTextareaFocus(false)"
@input.prevent.stop="changeValue" />
Expand Down Expand Up @@ -60,6 +61,12 @@ export default {
PropertyMixin,
PropertyLinksMixin,
],
props: {
isDescription: {
type: Boolean,
default: false,
},
},
computed: {
display() {
if (this.isReadOnly) {
Expand Down Expand Up @@ -94,3 +101,9 @@ export default {
},
}
</script>
<style lang="scss" scoped>
.textarea--description {
height: 120px;
overflow-y: auto;
}

Check warning on line 108 in src/components/Editor/Properties/PropertyText.vue

View check run for this annotation

Codecov / codecov/patch

src/components/Editor/Properties/PropertyText.vue#L105-L108

Added lines #L105 - L108 were not covered by tests
</style>
5 changes: 4 additions & 1 deletion src/components/Editor/Properties/PropertyTitleTimePicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,13 @@ export default {
overflow-y: clip !important;
flex-grow: 2;
flex-shrink: 1;
width: 210px;
width: 180px;
margin: 0;
min-width: unset;
}
:deep(.v-select.select) {
min-width: 180px !important;
}

Check warning on line 344 in src/components/Editor/Properties/PropertyTitleTimePicker.vue

View check run for this annotation

Codecov / codecov/patch

src/components/Editor/Properties/PropertyTitleTimePicker.vue#L344

Added line #L344 was not covered by tests

.property-title-time-picker__time-pickers {
flex-direction: column;
Expand Down
3 changes: 2 additions & 1 deletion src/views/EditSimple.vue
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@
:prop-model="rfcProps.description"
:value="description"
:linkify-links="true"
:is-description="true"

Check warning on line 133 in src/views/EditSimple.vue

View check run for this annotation

Codecov / codecov/patch

src/views/EditSimple.vue#L133

Added line #L133 was not covered by tests
@update:value="updateDescription" />

<InviteesList class="event-popover__invitees"
Expand Down Expand Up @@ -445,7 +446,7 @@ export default {
<style lang="scss" scoped>
.event-popover__inner {
width: unset !important;
min-width: 300px !important;
min-width: 500px !important;

Check warning on line 449 in src/views/EditSimple.vue

View check run for this annotation

Codecov / codecov/patch

src/views/EditSimple.vue#L449

Added line #L449 was not covered by tests
}
.modal-mask {
position: fixed;
Expand Down

0 comments on commit 11f766f

Please sign in to comment.