Skip to content

Improve error message when download fails due to invalid filename #11384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Improve error message when download fails due to invalid filename #11384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0445eb3
feat(download): Show specific error if download fails due to local fi…
AlvaroBrey Feb 14, 2023
a9e1609
feat(download): Show specific error message when download fails due t…
AlvaroBrey Feb 14, 2023
5bbb26c
Remove unused imports
AlvaroBrey Feb 17, 2023
7fd58b7
chore(build): Restore library version
AlvaroBrey Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/main/java/com/owncloud/android/utils/ErrorMessageAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,13 @@ String getMessageForDownloadFileOperation(
new File(operation.getSavePath()).getName());

} else {
if (result.getCode() == ResultCode.FILE_NOT_FOUND) {
return res.getString(R.string.downloader_download_file_not_found);

switch (result.getCode()) {
case FILE_NOT_FOUND:
return res.getString(R.string.downloader_download_file_not_found);
case CANNOT_CREATE_FILE:
return res.getString(R.string.download_cannot_create_file);
case INVALID_LOCAL_FILE_NAME:
return res.getString(R.string.download_download_invalid_local_file_name);
}
}
return null;
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,4 +1075,6 @@
<string name="document_scan_export_dialog_title">Choose export type</string>
<string name="document_scan_export_dialog_pdf">PDF file</string>
<string name="document_scan_export_dialog_images">Multiple images</string>
<string name="download_cannot_create_file">Cannot create local file</string>
<string name="download_download_invalid_local_file_name">Invalid filename for local file</string>
</resources>