Skip to content

Conversation

@AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Feb 14, 2023

Fixes #2711
Fixes #8523

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #11384 (7fd58b7) into master (53a5804) will increase coverage by 28.33%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #11384       +/-   ##
=============================================
+ Coverage      3.21%   31.54%   +28.33%     
- Complexity      438     3426     +2988     
=============================================
  Files           576      576               
  Lines         42132    42134        +2     
  Branches       5685     5685               
=============================================
+ Hits           1354    13293    +11939     
+ Misses        40691    26874    -13817     
- Partials         87     1967     +1880     
Impacted Files Coverage Δ
...om/owncloud/android/utils/ErrorMessageAdapter.java 3.33% <0.00%> (+3.33%) ⬆️
.../java/com/owncloud/android/datamodel/GalleryRow.kt 50.00% <0.00%> (ø)
...roid/ui/activity/ReceiveExternalFilesActivity.java 0.36% <0.00%> (+0.36%) ⬆️
...cloud/android/ui/preview/PreviewImageActivity.java 0.55% <0.00%> (+0.55%) ⬆️
...owncloud/android/ui/activity/UserInfoActivity.java 0.58% <0.00%> (+0.58%) ⬆️
...oud/android/ui/activity/NotificationsActivity.java 0.59% <0.00%> (+0.59%) ⬆️
...tcloud/client/database/migrations/RoomMigration.kt 0.75% <0.00%> (+0.75%) ⬆️
...ui/fragment/contactsbackup/BackupListFragment.java 0.94% <0.00%> (+0.94%) ⬆️
...loud/android/ui/activities/ActivitiesActivity.java 1.03% <0.00%> (+1.03%) ⬆️
...cloud/android/ui/activity/ExternalSiteWebView.java 1.12% <0.00%> (+1.12%) ⬆️
... and 286 more

@AlvaroBrey AlvaroBrey force-pushed the fix/invalid-filename-download branch from 8f5ff23 to 7fd58b7 Compare February 17, 2023 10:02
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11384.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

1 similar comment
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11384.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7676
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4444
Dodgy code331331
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total496496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download fails for files in folders with special characters Enhance error message when failing to sync file due to illegal filename

3 participants