Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Dec 7, 2022

Needs: nextcloud/android-library#435

Signed-off-by: tobiasKaminsky [email protected]

  • Tests written, or not not needed

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #11149 (08eea65) into master (b694ece) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 08eea65 differs from pull request most recent head eb25bc0. Consider uploading reports for the commit eb25bc0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11149      +/-   ##
============================================
+ Coverage     31.07%   31.10%   +0.02%     
- Complexity     3321     3329       +8     
============================================
  Files           565      565              
  Lines         41577    41577              
  Branches       5635     5635              
============================================
+ Hits          12919    12931      +12     
+ Misses        26715    26708       -7     
+ Partials       1943     1938       -5     
Impacted Files Coverage Δ
...cloud/android/ui/activity/SyncedFoldersActivity.kt 20.98% <0.00%> (-0.23%) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 27.16% <0.00%> (+0.08%) ⬆️
.../java/com/owncloud/android/utils/DisplayUtils.java 37.97% <0.00%> (+0.86%) ⬆️
...ain/java/com/owncloud/android/db/UploadResult.java 39.74% <0.00%> (+1.28%) ⬆️
...cloud/android/datamodel/UploadsStorageManager.java 72.06% <0.00%> (+1.90%) ⬆️
.../third_parties/daveKoeller/AlphanumComparator.java 88.09% <0.00%> (+2.38%) ⬆️

@tobiasKaminsky
Copy link
Member Author

/rebase

@tobiasKaminsky
Copy link
Member Author

/rebase

@AlvaroBrey
Copy link
Member

/rebase

1 similar comment
@tobiasKaminsky
Copy link
Member Author

/rebase

@tobiasKaminsky
Copy link
Member Author

/rebase

@nextcloud-android-bot
Copy link
Collaborator

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11149.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7676
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4444
Dodgy code331331
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total496496

@github-actions
Copy link

@AlvaroBrey AlvaroBrey merged commit f91abef into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the mTimestamp branch February 22, 2023 16:21
@AlvaroBrey AlvaroBrey added this to the Nextcloud App 3.25.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants