Skip to content

UploadRemoteOperation: use long instead of String for modificationTime #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2023
Merged

UploadRemoteOperation: use long instead of String for modificationTime #435

merged 4 commits into from
Feb 22, 2023

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented May 11, 2020 •
edited
Loading

For: nextcloud/android#11149

Signed-off-by: tobiasKaminsky [email protected]

@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 7, 2022
Merged
1 task
@github-actions github-actions bot deleted a comment from nextcloud-android-bot Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions github-actions bot deleted a comment from nextcloud-android-bot Dec 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Merging #435 (8f4f979) into master (da77680) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   49.33%   49.34%   +0.01%     
==========================================
  Files         180      180              
  Lines        6750     6750              
  Branches      897      896       -1     
==========================================
+ Hits         3330     3331       +1     
  Misses       2952     2952              
+ Partials      468      467       -1
Impacted Files Coverage Δ
...ources/files/ChunkedFileUploadRemoteOperation.java 25.38% <0.00%> (-0.20%) ⬇️
...lib/resources/files/UploadFileRemoteOperation.java 53.68% <100.00%> (+1.60%) ⬆️

AlvaroBrey
AlvaroBrey previously approved these changes Dec 13, 2022
View reviewed changes
@AlvaroBrey AlvaroBrey changed the title use typed parameter (long) instead of String UploadRemoteOperation: use long instead of String for modificationTime Dec 13, 2022
@AlvaroBrey
Copy link
Member

AlvaroBrey commented Dec 16, 2022

/rebase

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Dec 16, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Feb 8, 2023

@AlvaroBrey can you review this please? 💙

AlvaroBrey
AlvaroBrey previously approved these changes Feb 22, 2023
View reviewed changes
tobiasKaminsky and others added 2 commits February 22, 2023 14:45
@tobiasKaminsky @AlvaroBrey
More changes
588f79c 
Signed-off-by: tobiasKaminsky <[email protected]>
@AlvaroBrey
Suppress MagicNumber for timestamps in tests
8f4f979 
Signed-off-by: Álvaro Brey <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

@AlvaroBrey AlvaroBrey merged commit 9270a19 into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the ufo branch February 22, 2023 15:09
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.15.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey approved these changes

Assignees

No one assigned

Labels

2. developing client change required

Projects

None yet

Milestone

NC Android Lib 2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasKaminsky @AlvaroBrey