Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

I added a test for above PR.
While doing this, I noticed that response of UploadFileRemoteOperation is "etag", but in RemoteFile we use etag (without " ").
I think this should be consistent across lib and therefore removed "" in UFRO.

What do you think? @AlvaroBrey @vince-bourgmayer

Signed-off-by: tobiasKaminsky [email protected]

Signed-off-by: tobiasKaminsky <[email protected]>
@nextcloud-android-bot
Copy link
Collaborator

SpotBugs (new)

Warning Type Number
Bad practice Warnings 11
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 54
Multithreaded correctness Warnings 3
Performance Warnings 14
Security Warnings 1
Dodgy code Warnings 45
Total 170

SpotBugs (master)

Warning Type Number
Bad practice Warnings 11
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 54
Multithreaded correctness Warnings 3
Performance Warnings 14
Security Warnings 1
Dodgy code Warnings 45
Total 170

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #874 (0a9fd6c) into master (377e342) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #874   +/-   ##
=======================================
  Coverage   48.13%   48.13%           
=======================================
  Files         168      168           
  Lines        6484     6484           
  Branches      847      847           
=======================================
  Hits         3121     3121           
  Misses       2907     2907           
  Partials      456      456           
Impacted Files Coverage Δ
...lib/resources/files/UploadFileRemoteOperation.java 52.08% <100.00%> (ø)

@tobiasKaminsky tobiasKaminsky merged commit 5ee07b1 into master Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the etagTest branch April 27, 2022 12:12
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.11.0 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants