-
Notifications
You must be signed in to change notification settings - Fork 95
Update UploadFileRemoteOperation.java to get access to etag from resp… #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UploadFileRemoteOperation.java to get access to etag from resp… #870
Conversation
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
==========================================
+ Coverage 48.09% 48.13% +0.03%
==========================================
Files 168 168
Lines 6481 6484 +3
Branches 846 847 +1
==========================================
+ Hits 3117 3121 +4
+ Misses 2908 2907 -1
Partials 456 456
|
AlvaroBrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but since the RemoteOperationResult has result data, it should be parameterized.
For this:
UploadFileRemoteOperationshould extendRemoteOperation<String>rather than the raw type- Variables and return types should be
RemoteOperationResult<String>(orRemoteOperationResult<>where applicable) rather than the raw type.
|
@vince-bourgmayer Please fix DCO (https://github.com/nextcloud/android-library/pull/870/checks?check_run_id=6127967707) and this will be ready to merge |
…onse header - Add a private static final value which is the response header's name for etag. - update 'RemoteOperationResult uploadFile(OwnCloudClient client)' to check for this header, and set value as RemoteOperationResult's data. Signed-off-by: vincent Bourgmayer <[email protected]>
…raw type Signed-off-by: vincent Bourgmayer <[email protected]>
5228613 to
01f0cb2
Compare
@AlvaroBrey DCO has been fixed |
SpotBugs (new)
SpotBugs (master)
|
|
Thank you @vince-bourgmayer ! |
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
…onse header