-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate conflictpicker to NcDialog and remove incorrect semantic closing icon #1113
Conversation
@@ -372,7 +373,7 @@ export default Vue.extend({ | |||
position: sticky; | |||
z-index: 10; | |||
top: 0; | |||
padding: var(--margin); | |||
padding: 0 var(--margin); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lessen the padding for the header, as without this, the header has more padding than previously and looks really bloated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
d1107ff
to
54fe138
Compare
Cypress seems related - will fix 👍 |
… closing icon Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: Eduardo Morales <[email protected]>
a3a66eb
to
87da200
Compare
Fixed Cypress tests - also updated one section to reflect that we no longer have the default modal close button, and instead should always use the |
@emoral435 this broke a feature. The close icon was used to know if the user wanted to stop the process entirely.
I will fix it in a followup and add a third dedicated cancel button EDIT: #1123 |
Ahh, I see. I will check out the PR you mention in the comment, but thank you for the catch! :) |
Resolves #1095
Summary
Video
firefox_9NKju1QCHo.mp4