Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] Close button is not clickable when ConflictPicker is opened #1095

Closed
emoral435 opened this issue Feb 21, 2024 · 1 comment · Fixed by #1113
Closed

[a11y] Close button is not clickable when ConflictPicker is opened #1095

emoral435 opened this issue Feb 21, 2024 · 1 comment · Fixed by #1113
Assignees
@emoral435
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@emoral435
Copy link
Contributor

See: nextcloud/server#43667 (comment)

It seems that the close button on the ConflictPicker is not currently accessible with a mouse cursor. It does seem related to its z-index, so I will investigate this ASAP!
@emoral435 emoral435 added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Feb 21, 2024
@emoral435 emoral435 self-assigned this Feb 21, 2024
@susnux
Copy link
Contributor

susnux commented Feb 22, 2024

I think migrating from NcModal to NcDialog should fix this.

We had this also on photos.

@emoral435 emoral435 mentioned this issue Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoral435 emoral435

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@susnux @emoral435