Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show close button #7007

Conversation

azeek21
Copy link
Contributor

@azeek21 azeek21 commented Mar 20, 2023

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

Docusaurus lacking a feature to set announcementBar close button color in their config file. For now color of close button comes directly from infima which Docusaurus relies on. At least changing it to inherit text color of announcementBar would be a good idea. Ideally, should be possible with config, but they don't have this feature yet.

I changed the global styles file so that it inherits text color of annoucementBar which is set here

textColor: "#fff",

this should do the job for most of the time. Also I am going to go open an issue and a PR in Docusaurus to add option to set color of close button directly from config file.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

#6935

Please scout and link issues that might be solved by this PR.

Fixes: #6935

📌 Resources

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ❌ Failed (Inspect) Mar 20, 2023 at 9:27AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth-docs ⬜️ Ignored (Inspect) Mar 20, 2023 at 9:27AM (UTC)

@balazsorban44 balazsorban44 changed the title fix #6935: show close button. docs: show close button Mar 20, 2023
@balazsorban44 balazsorban44 merged commit 2e09bc0 into nextauthjs:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

announcementBar announcement close button invisible.
2 participants