Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

announcementBar announcement close button invisible. #6935

Closed
azeek21 opened this issue Mar 13, 2023 · 2 comments · Fixed by #7007
Closed

announcementBar announcement close button invisible. #6935

azeek21 opened this issue Mar 13, 2023 · 2 comments · Fixed by #7007
Assignees
@ndom91
Labels
documentation Relates to documentation good first issue Good issue to take for first time contributors

Comments

@azeek21
Copy link
Contributor

azeek21 commented Mar 13, 2023 •
edited
Loading

What is the improvement or update you wish to see?

The button to close the announcement is being invisible as background color of announcementBar and color of close button are the same.

Screenshot: imgur link

Not sure if this is intended or not. Color for close button comes from Docusaurus and I think can be overwritten by custom global css.

Is there any context that might help us understand?

imgur link

Does the docs page already exist? Please link to it.

https://authjs.dev/
@azeek21 azeek21 added documentation Relates to documentation triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Mar 13, 2023
@balazsorban44 balazsorban44 added good first issue Good issue to take for first time contributors and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Mar 16, 2023
@azeek21
Copy link
Contributor Author

azeek21 commented Mar 16, 2023 •
edited
Loading

@ndom91
I actually have the fix ready. Can't decide on style. What color do you want close the announcement button to be ? I would recommend red.

@ndom91
Copy link
Member

ndom91 commented Mar 19, 2023

Yeah if you have a PR you can put up, we'd be happy to take a look.

I think color: white would suffice here 👍

Something like this:
image

azeek21 added a commit to azeek21/next-auth that referenced this issue Mar 20, 2023
@azeek21
fix nextauthjs#6935: show close button.
87838d2
@azeek21 azeek21 mentioned this issue Mar 20, 2023
Merged
3 tasks
azeek21 added a commit to azeek21/next-auth that referenced this issue Mar 26, 2023
@azeek21
Merge branch 'nextauthjs:main' into fix(announcement-bar-close-button)-…
97cb595 
…nextauthjs#6935
ndom91 pushed a commit that referenced this issue Mar 26, 2023
@azeek21
chore(docs): show close button on announcementBar (#7074)
6184b93 
* fix #6935: show close button.

* fix(global-css): show close button on annoucement bar

dev and build were generating different results, adding `!important` fixed on build.
@naiba4 naiba4 mentioned this issue May 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndom91 ndom91

Labels
documentation Relates to documentation good first issue Good issue to take for first time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: show close button azeek21/next-auth
3 participants
@ndom91 @balazsorban44 @azeek21