Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module version to match tag major version #2769

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore(deps): update module version to match tag major version #2769

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
549fd54
chore(deps): update module version to match tag major version
smcavallo Oct 31, 2024
7140320
Merge branch 'main' into go-mod-version
smcavallo Nov 14, 2024
22b23bf
Merge branch 'main' into go-mod-version
smcavallo Jan 2, 2025
7fc4177
Merge branch 'main' into go-mod-version
smcavallo Jan 3, 2025
30907fd
Merge branch 'main' into go-mod-version
smcavallo Jan 9, 2025
2ddbf4d
Update go.mod toolchain
smcavallo Jan 9, 2025
89fd846
Update go.mod toolchain
smcavallo Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/newrelic/terraform-provider-newrelic/v2
module github.com/newrelic/terraform-provider-newrelic/v3

go 1.22

toolchain go1.22.6
toolchain go1.22.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @smcavallo Thank you for your contribution. Could you please share if there was a specific reason or any particular issue that prompted you to update the toolchain version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vagrawal-newrelic - yes - it was because some of the community images were patching the toolchain version to address this CVE -> https://nvd.nist.gov/vuln/detail/CVE-2024-24790#range-13244817
See - https://go.dev/doc/devel/release#go1.22.minor

Updating the toolchain version was purely driven by addressing that CVE on my part. There was no functional reason for the update. I can revert back to go1.22.6 and submit this change in a separate PR if that would make sense. Please let me know. Thank you so much for reviewing this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smcavallo for the details. Can you raise a PR against the new branch (bump-toolchain-go-version) . Since the current PR is from a forked repo we are unable to run the integration tests to ensure no outage of the current functionalities because of the version upgrade

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagrawal-newrelic - all set - I removed the toolchain version changes so this PR is only versioning changes which should allow the newer v3 version to be published to the go artifact registry (and align with best practice)


require (
github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
Expand Down
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/hashicorp/terraform-plugin-sdk/v2/plugin"

"github.com/newrelic/terraform-provider-newrelic/v2/newrelic"
"github.com/newrelic/terraform-provider-newrelic/v3/newrelic"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/newrelic/terraform-provider-newrelic/v2/tools
module github.com/newrelic/terraform-provider-newrelic/v3/tools

go 1.22

toolchain go1.22.6
toolchain go1.22.8

require (
github.com/bflad/tfproviderlint v0.29.0
Expand Down