-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update module version to match tag major version #2769
base: main
Are you sure you want to change the base?
Conversation
go.mod
Outdated
|
||
go 1.22 | ||
|
||
toolchain go1.22.6 | ||
toolchain go1.22.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @smcavallo Thank you for your contribution. Could you please share if there was a specific reason or any particular issue that prompted you to update the toolchain version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vagrawal-newrelic - yes - it was because some of the community images were patching the toolchain version to address this CVE -> https://nvd.nist.gov/vuln/detail/CVE-2024-24790#range-13244817
See - https://go.dev/doc/devel/release#go1.22.minor
Updating the toolchain version was purely driven by addressing that CVE on my part. There was no functional reason for the update. I can revert back to go1.22.6
and submit this change in a separate PR if that would make sense. Please let me know. Thank you so much for reviewing this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smcavallo for the details. Can you raise a PR against the new branch (bump-toolchain-go-version) . Since the current PR is from a forked repo we are unable to run the integration tests to ensure no outage of the current functionalities because of the version upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagrawal-newrelic - all set - I removed the toolchain version changes so this PR is only versioning changes which should allow the newer v3 version to be published to the go artifact registry (and align with best practice)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 32.82% 31.01% -1.81%
==========================================
Files 98 101 +3
Lines 26884 27472 +588
==========================================
- Hits 8824 8520 -304
- Misses 17902 18786 +884
- Partials 158 166 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo <[email protected]>
Signed-off-by: smcavallo [email protected]
Description
Update module version to match tag version.
The ultimate goal is to allow this module to be published to the go artifact registry
The latest current version there is 2.50.2 which is the last version 2 which was tagged.
See on the registry - https://pkg.go.dev/github.com/newrelic/terraform-provider-newrelic/v2
See the tags - https://github.com/newrelic/terraform-provider-newrelic/releases?page=10
Bumping to /v3 to match the tag version and enable an artifact to be published.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc