Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrated @newrelic/koa into mainline agent repo #2148

Merged
merged 451 commits into from
Apr 17, 2024
Merged

chore: Migrated @newrelic/koa into mainline agent repo #2148

merged 451 commits into from
Apr 17, 2024

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Apr 16, 2024 •
edited by bizob2828
Loading

This PR resolves #2126.

michaelgoin and others added 30 commits July 13, 2020 15:18
@michaelgoin
Adds additional files to npm ignore.
1df7952
@astormnewrelic
Merge pull request newrelic#63 from michaelgoin/update-npm-ignore
5e62c03 
Adds additional files to npm ignore.
@michaelgoin
Adds additional dependency language to bottom of third party notices.
2225ebc
@michaelgoin
Merge pull request newrelic#64 from michaelgoin/add-notices-language
80efd2f 
Adds additional dependency language to bottom of third party notices.
Updates to Readme, guidelines and templates
db9624e
updated security policy link
2fcce90
updates to templates and readme
d8b4098
template updates
4f250e3
Contributing doc update
a8085e4
@carlo-808 @michaelgoin
Update CONTRIBUTING.md
4f0b231 
Co-authored-by: Michael Goin <[email protected]>
@michaelgoin
Merge pull request newrelic#65 from newrelic/carlonewrelic/guidelines…
432db17 
…_updates

Updates to Readme, guidelines and templates
@michaelgoin
Bumps node-test-utilities to ^4.0.0.
6792686
@michaelgoin
Merge pull request newrelic#66 from michaelgoin/bump-test-utils
d6710b1 
Bumps node-test-utilities to ^4.0.0.
@nikostoulas
Null check for context.matched
22e6b71 
We are using fast-koa-router that set's _matchedRoute but does not set context.matched.
See https://github.com/nikostoulas/fast-koa-router/blob/master/src/router.ts#L12
Updating to latest newrelic library breaks our apps.
@astormnewrelic
Merge pull request newrelic#29 from nikostoulas/patch-1
84c879e 
Null check for context.matched
@tangollama
ci: Add Open Source Policy Workflow
58e03be
@carlo-808
Merge pull request newrelic#67 from newrelic/feature/repolinter-action
e97049f 
ci: Add Open Source Policy Workflow
Update readme with community-plus header
917b62e
@michaelgoin
Merge pull request newrelic#69 from newrelic/carlo/readme-community-plus
d03e00f 
Update readme with community-plus header
@jgeurts
Check if transaction is null before accessing nameState property
bdd127d 
Fix newrelic#32 and fix newrelic#33
@nijotz
Merge pull request newrelic#70 from jgeurts/issue-33
603d9f7 
Check if transaction is null before accessing nameState property
@nijotz
Add a test for null transaction
525a9fb
@jgeurts
Add Node.js 14 to CI
c1cc2f6
@michaelgoin
Merge pull request newrelic#72 from nijotz/test-for-null-tx-check
6e78a81 
Add a test for null transaction
@paperclypse
Updated README as part of the repo consistency project
bb23933 
For context:
https://docs.google.com/document/d/1JIog8rJL9MT6_AbIji8VK_RT3mOuIxC2Xb_xQsVksKk/edit#

https://newrelic.atlassian.net/browse/DOC-6121
@michaelgoin
Merge pull request newrelic#73 from jgeurts/node-14
34b9ffa 
Add Node.js 14 to CI
@michaelgoin
Merge pull request newrelic#74 from paperclypse/main
81ab318 
Updated README as part of the repo consistency project
@michaelgoin
Updates release notes for 4.1.0 release.
57614fd
@michaelgoin
Merge pull request newrelic#76 from newrelic/v4.1.0
41552d2 
Release 4.1.0
@michaelgoin
4.1.0
d1a8da3
svetlanabrennan and others added 12 commits March 18, 2024 09:10
@svetlanabrennan
Merge pull request newrelic#173 from newrelic/dependabot/npm_and_yarn…
60d5f1a 
…/follow-redirects-1.15.6

build(deps-dev): bump follow-redirects from 1.15.5 to 1.15.6
@bizob2828
chore: updated recordParamware to construct spec
168fdf5
@bizob2828
Merge pull request newrelic#175 from newrelic/fix-paramware
b2068d2
@svetlanabrennan
chore: Updated CI process for releases (newrelic#176)
cbf31f2
@svetlanabrennan
test: Removed v1 versioned tests (newrelic#177)
7da8ac6
@bizob2828
ci: Fixed spelling of use_new_release in prepare-release.yml (newre…
8ab4637 
…lic#178)
@bizob2828
ci: Fixed changelog_file to be NEWS.md (newrelic#179)
e8fe445
@github-actions
chore: release v9.1.0 (newrelic#180)
e9974b6
@svetlanabrennan
ci: removed changelog.json file (newrelic#181)
aedc482
@svetlanabrennan
ci: Removed use_new_release input from prepare release workflow (ne…
54db8c4 
…wrelic#182)
@jsumners-nr
chore: Merged koa external repo into newrelic repo
dc7acd0
@jsumners-nr
refactor koa into newrelic repo structure
a338a21
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.58763% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 97.23%. Comparing base (38e47d9) to head (a338a21).

❗ Current head a338a21 differs from pull request most recent head 28d478b. Consider uploading reports for the commit 28d478b to get more accurate results

Files Patch % Lines
lib/instrumentation/koa/lib/instrumentation.js 90.50% 17 Missing ⚠️
.../instrumentation/koa/lib/router-instrumentation.js 96.63% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   97.25%   97.23%   -0.02%     
==========================================
  Files         251      257       +6     
  Lines       42338    42725     +387     
==========================================
+ Hits        41175    41545     +370     
- Misses       1163     1180      +17
Flag Coverage Δ
integration-tests-16.x 78.02% <24.74%> (-0.54%) ⬇️
integration-tests-18.x 78.00% <24.74%> (-0.53%) ⬇️
integration-tests-20.x 78.01% <24.74%> (-0.54%) ⬇️
unit-tests-16.x 89.88% <41.49%> (-0.47%) ⬇️
unit-tests-18.x 89.79% <41.49%> (-0.47%) ⬇️
unit-tests-20.x 89.79% <41.49%> (-0.47%) ⬇️
versioned-tests-16.x 75.07% <93.29%> (+0.28%) ⬆️
versioned-tests-18.x 76.16% <93.29%> (+0.27%) ⬆️
versioned-tests-20.x 76.16% <93.29%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 marked this pull request as ready for review April 17, 2024 19:35
@bizob2828 bizob2828 self-assigned this Apr 17, 2024
@bizob2828
chore: migrated koa versioned tests to use agent_helper, moved symbol…
28d478b 
…s to lib/symbols, consolidated koa instrumentation into one folder
@bizob2828 bizob2828 merged commit 33af646 into newrelic:main Apr 17, 2024
22 checks passed
@jsumners-nr jsumners-nr deleted the issue-2126 branch April 23, 2024 12:34
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Merged
@Babbz86 Babbz86 mentioned this pull request Jul 30, 2024
Open
@ZinxValkyria ZinxValkyria mentioned this pull request Aug 3, 2024
Open
@coderisnot coderisnot mentioned this pull request Aug 17, 2024
Open
@Abhi9705 Abhi9705 mentioned this pull request Aug 21, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizob2828 bizob2828 bizob2828 approved these changes

@mrickard mrickard mrickard approved these changes

Assignees

@bizob2828 bizob2828

Labels
None yet
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate @newrelic/koa into repo