fix TypeError: Object.keys called on non-object

[willin]

Bug fixed under Restify (almost the same with express.js)

Error 1:

TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.parseParameters (/home/open-api/node_modules/newrelic/lib/util/urltils.js:77:14)
    at TraceSegment.markAsWeb (/home/open-api/node_modules/newrelic/lib/transaction/trace/segment.js:91:32)
    at ServerResponse.instrumentedFinish (/home/open-api/node_modules/newrelic/lib/instrumentation/core/http.js:126:15)
    at ServerResponse.g (events.js:199:16)
    at ServerResponse.<anonymous> (/home/open-api/node_modules/newrelic/node_modules/continuation-local-storage/context.js:74:17)
    at ServerResponse.emit (events.js:104:17)
    at ServerResponse.emitted [as emit] (/home/open-api/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/emitter-listener/listener.js:122:21)
    at finish (_http_outgoing.js:517:10)
    at /home/open-api/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:188:31js-bson: Failed to load c++ bson extension, using pure JS version

Error 2:

Error: Can't set headers after they are sent.
    at ServerResponse.OutgoingMessage.setHeader (_http_outgoing.js:331:11)
    at ServerResponse.format (/home/open-api/node_modules/restify/lib/response.js:95:10)
    at ServerResponse.send (/home/open-api/node_modules/restify/lib/response.js:205:24)
    at Server.<anonymous> (/home/open-api/app.js:99:8)
    at Server.emit (events.js:129:20)
    at Domain.onError (/home/open-api/node_modules/restify/lib/server.js:775:18)
    at Domain.emit (events.js:107:17)
    at Domain.errorHandler [as _errorHandler] (domain.js:102:19)
    at process._fatalException (node.js:234:33)
    at process._asyncFatalException [as _fatalException] (/home/open-api/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:211:34).write(string, encoding, offset, length) is deprecated. Use write(string[, offset[, length]][, encoding]) instead.

[wraithan]

@willin Can you give reproduction cases for this? Our tests aren't failing. I can adapt the repro into a test to prove there is a problem before I merge this as I can't repro it locally.

[willin]

I have no idea about it.
Our applications could not trace the error.

server.use(restify.acceptParser(server.acceptable));
    server.use(restify.dateParser());
    server.use(restify.queryParser());
    server.use(restify.jsonp());
    server.use(restify.gzipResponse());
    server.use(restify.bodyParser({
        mapParams: false
    }));
    server.get(/^\/((.*)(\.)(.+))*$/, restify.serveStatic({ directory: 'public', default: "index.html" }));

When Error1 occurred, the application will auto restart, during this period, the Error2 may happen.

Why check the parsed.search value but to operate the parsed.query?

[derEremit]

stumbled upon this or similar bug when switching node binaries if that helps.
exact same codebase
with node 0.10.30 no problem
with node 0.11.14

urltils.js:77
      Object.keys(parsed.query).forEach(function cb_forEach(key) {
             ^
TypeError: Object.keys called on non-object
    at Function.keys (native)
    at Object.parseParameters (/home/zen/projects/cmd/api/node_modules/newrelic/lib/util/urltils.js:77:14)
    at TraceSegment.markAsWeb (/home/zen/projects/cmd/api/node_modules/newrelic/lib/transaction/trace/segment.js:91:32)
    at ServerResponse.instrumentedFinish (/home/zen/projects/cmd/api/node_modules/newrelic/lib/instrumentation/core/http.js:96:15)
    at ServerResponse.g (events.js:199:16)
    at ServerResponse.<anonymous> (/home/zen/projects/cmd/api/node_modules/newrelic/node_modules/continuation-local-storage/context.js:74:17)
    at ServerResponse.emit (events.js:104:17)
    at ServerResponse.emitted [as emit] (/home/zen/projects/cmd/api/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/emitter-listener/listener.js:122:21)
    at finish (_http_outgoing.js:517:10)
    at /home/zen/projects/cmd/api/node_modules/newrelic/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:188:31

[wraithan]

Prerelease versions of node are not supported. Only full release versions of 0.8 and higher are supported. That said, I'm all for trying to make our support of 0.11.x work better so we have less to do when 0.12 comes out. I've been waiting on 0.11.15 (which has a major bump to v8 versions) in it before I started testing heavily on 0.11.x.

I know that we accepted a patch a week or to back that fixed on 0.11 bug in the area you are seeing problems. So make sure you're on the latest version of the agent. I'm accepted the last one because it was a very simple change and tests were 100% fine, but it appears we either didn't fix the whole problem or something else is up. In which case we need to expand our tests to be more robust and actually expose this 0.11 only bug.

[hayes]

Closing this, we have made a lot of improvements since 0.12 was released, have not been able to reproduce this issue