Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated versioned security agent workflow #2100

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Mar 27, 2024

This PR resolves #2088. It adds a new job to the versioned-security-agent workflow that detects if the package.json has been updated, and if so, whether or not the @newrelic/security-agent version number has been changed. The results of this job are utilized by the already existing job to determine if it should run. After this PR there are three cases where the versioned tests will run with the security agent enabled:

  1. When the workflow is directly run through the GitHub interface.
  2. When nightly scheduled job is executed.
  3. When a pull request includes a change in the version for the @newrelic/security-agent dependency.

Note: the CI run https://github.com/newrelic/node-newrelic/actions/runs/8455455203/job/23162959574?pr=2100 as a result of opening this PR shows that the security agent enabled tests do not run for every PR (this PR does not change the dependency version).

@jsumners-nr jsumners-nr added the dev:automation Indicates CI automation label Mar 27, 2024
@mrickard mrickard self-assigned this Mar 27, 2024
Copy link
Member

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsumners-nr jsumners-nr merged commit f787b15 into newrelic:main Mar 27, 2024
25 checks passed
@jsumners-nr jsumners-nr deleted the issue-2088 branch March 27, 2024 16:53
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement security agent testing on PRs for security agent updates
2 participants