Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement security agent testing on PRs for security agent updates #2088

Closed
jsumners-nr opened this issue Mar 20, 2024 · 1 comment · Fixed by #2100
Closed

Implement security agent testing on PRs for security agent updates #2088

jsumners-nr opened this issue Mar 20, 2024 · 1 comment · Fixed by #2100
Assignees
Labels

Comments

@jsumners-nr
Copy link
Contributor

jsumners-nr commented Mar 20, 2024

Description

When the security agent team issues a new release the submit a pull request (PR) to use to bump the version, e.g. #2080. However, our continuous integration (CI) setup only runs the standard tests suites, which do not enable the security agent, for all PRs. So it is possible for us to see breakages when the nightly tests run that do enable the security agent, e.g. #2087

Acceptance Criteria

  1. Update the CI configuration to enable the security agent when the PR contains a change to the security agent dependency version such that CI enables the security agent for the runs against the PR
  2. Change the security agent dependency to a pinned version instead of a semver qualifier range of ^ (solved in chore(deps): pin @newrelic/security-agent to 1.0.1 #2089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant